Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc

Issue 143003031: Allow retrieval of media device ID salt even after ResourceContext has gone away. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add TODO about proper fix. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
diff --git a/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc b/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
index b33a3ee40758aec86588346dec60ac40b6d534b5..bc0cf67007c166fe49fcd24e1bc52b11d2f73185 100644
--- a/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
+++ b/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
@@ -332,10 +332,10 @@ class MediaStreamDispatcherHostTest : public testing::Test {
physical_audio_devices_.begin();
for (; audio_it != physical_audio_devices_.end(); ++audio_it) {
if (content::DoesMediaDeviceIDMatchHMAC(
- browser_context_.GetResourceContext(),
- origin,
- devices[i].device.id,
- audio_it->unique_id)) {
+ browser_context_.GetResourceContext()->GetMediaDeviceIDSalt(),
+ origin,
+ devices[i].device.id,
+ audio_it->unique_id)) {
EXPECT_FALSE(found_match);
found_match = true;
}
@@ -344,10 +344,10 @@ class MediaStreamDispatcherHostTest : public testing::Test {
physical_video_devices_.begin();
for (; video_it != physical_video_devices_.end(); ++video_it) {
if (content::DoesMediaDeviceIDMatchHMAC(
- browser_context_.GetResourceContext(),
- origin,
- devices[i].device.id,
- video_it->id())) {
+ browser_context_.GetResourceContext()->GetMediaDeviceIDSalt(),
+ origin,
+ devices[i].device.id,
+ video_it->id())) {
EXPECT_FALSE(found_match);
found_match = true;
}
@@ -537,7 +537,7 @@ TEST_F(MediaStreamDispatcherHostTest, GenerateStreamsWithMandatorySourceId) {
physical_audio_devices_.begin();
for (; audio_it != physical_audio_devices_.end(); ++audio_it) {
std::string source_id = content::GetHMACForMediaDeviceID(
- browser_context_.GetResourceContext(),
+ browser_context_.GetResourceContext()->GetMediaDeviceIDSalt(),
origin_,
audio_it->unique_id);
ASSERT_FALSE(source_id.empty());
@@ -553,7 +553,7 @@ TEST_F(MediaStreamDispatcherHostTest, GenerateStreamsWithMandatorySourceId) {
physical_video_devices_.begin();
for (; video_it != physical_video_devices_.end(); ++video_it) {
std::string source_id = content::GetHMACForMediaDeviceID(
- browser_context_.GetResourceContext(),
+ browser_context_.GetResourceContext()->GetMediaDeviceIDSalt(),
origin_,
video_it->id());
ASSERT_FALSE(source_id.empty());
@@ -576,7 +576,7 @@ TEST_F(MediaStreamDispatcherHostTest, GenerateStreamsWithOptionalSourceId) {
physical_audio_devices_.begin();
for (; audio_it != physical_audio_devices_.end(); ++audio_it) {
std::string source_id = content::GetHMACForMediaDeviceID(
- browser_context_.GetResourceContext(),
+ browser_context_.GetResourceContext()->GetMediaDeviceIDSalt(),
origin_,
audio_it->unique_id);
ASSERT_FALSE(source_id.empty());
@@ -592,7 +592,7 @@ TEST_F(MediaStreamDispatcherHostTest, GenerateStreamsWithOptionalSourceId) {
physical_video_devices_.begin();
for (; video_it != physical_video_devices_.end(); ++video_it) {
std::string source_id = content::GetHMACForMediaDeviceID(
- browser_context_.GetResourceContext(),
+ browser_context_.GetResourceContext()->GetMediaDeviceIDSalt(),
origin_,
video_it->id());
ASSERT_FALSE(source_id.empty());

Powered by Google App Engine
This is Rietveld 408576698