Issue 1429943002: Merge to XFA: Add tests for CMap_GetCode and CMap_GetCodeRange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1429943002: Merge to XFA: Add tests for CMap_GetCode and CMap_GetCodeRange. (Closed)

Created:
5 years, 1 month ago by dsinclair

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Add tests for CMap_GetCode and CMap_GetCodeRange. This CL adds tests for the CMap_GetCode and CMap_GetCodeRange methods. To do so, it moves the methods to be static private members of CPDF_CMapParser and makes the test class a friend. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1414013005 . (cherry picked from commit afca65ac019d2ad4cb8ac8f585809cc1a519ac2b) Committed: https://pdfium.googlesource.com/pdfium/+/bd55239e7825b8d10255093d8c3fa03b43620a98

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -72 lines)			Patch
M	BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_font/font_int.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp	View	2 chunks	+76 lines, -72 lines	0 comments	Download
A	core/src/fpdfapi/fpdf_font/fpdf_font_cid_unittest.cpp	View	1 chunk	+66 lines, -0 lines	0 comments	Download
M	pdfium.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

dsinclair

5 years, 1 month ago (2015-11-02 21:26:58 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bd55239e7825b8d10255093d8c3fa03b43620a98 (presubmit successful).