Add tests for CMap_GetCode and CMap_GetCodeRange.

Add tests for CMap_GetCode and CMap_GetCodeRange.

This CL adds tests for the CMap_GetCode and CMap_GetCodeRange methods. To do
so, it moves the methods to be static private members of CPDF_CMapParser and
makes the test class a friend.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/afca65ac019d2ad4cb8ac8f585809cc1a519ac2b

[dsinclair, 2015-11-02 19:10:35]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2015-11-02 19:10:36]

PTAL.

https://codereview.chromium.org/1414013005/diff/1/core/src/fpdfapi/fpdf_font/...
File core/src/fpdfapi/fpdf_font/fpdf_font_cid_unittest.cpp (right):

https://codereview.chromium.org/1414013005/diff/1/core/src/fpdfapi/fpdf_font/...
core/src/fpdfapi/fpdf_font/fpdf_font_cid_unittest.cpp:52:
EXPECT_TRUE(uint_ranges_equal(upper, range.m_Upper, range.m_CharSize));
This seemed a little nicer then repeating the EXPECT_EQ 8 times, but not a lot
....

[dsinclair, 2015-11-02 19:11:09]

https://codereview.chromium.org/1414013005/diff/1/core/src/fpdfapi/fpdf_font/...
File core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp (right):

https://codereview.chromium.org/1414013005/diff/1/core/src/fpdfapi/fpdf_font/...
core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp:764: : '0';
I fixed the issue where this was 0 instead of '0' in order to make the tests
pass, otherwise the result doesn't make sense.

[Tom Sepez, 2015-11-02 21:00:54]

lgtm

https://codereview.chromium.org/1414013005/diff/1/core/src/fpdfapi/fpdf_font/...
File core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp (right):

https://codereview.chromium.org/1414013005/diff/1/core/src/fpdfapi/fpdf_font/...
core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp:764: : '0';
On 2015/11/02 19:11:09, dsinclair wrote:
> I fixed the issue where this was 0 instead of '0' in order to make the tests
> pass, otherwise the result doesn't make sense.

Acknowledged.

[dsinclair, 2015-11-02 21:15:29]

Committed patchset #2 (id:20001) manually as
afca65ac019d2ad4cb8ac8f585809cc1a519ac2b (presubmit successful).