Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 1429903005: Fix ChromeActivityTestCaseBase.loadUrlInNewTab() for document mode. (Closed)

Created:
5 years, 1 month ago by Dmitry Skiba
Modified:
5 years, 1 month ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ChromeActivityTestCaseBase.loadUrlInNewTab() for document mode. BUG=550634 Committed: https://crrev.com/7e461843c23fbb430a7f0554238027a61100f2c1 Cr-Commit-Position: refs/heads/master@{#357489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java View 1 chunk +1 line, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dmitry Skiba
5 years, 1 month ago (2015-11-02 23:48:25 UTC) #2
Ted C
lgtm
5 years, 1 month ago (2015-11-02 23:51:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429903005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429903005/1
5 years, 1 month ago (2015-11-03 00:35:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 00:41:55 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 00:43:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e461843c23fbb430a7f0554238027a61100f2c1
Cr-Commit-Position: refs/heads/master@{#357489}

Powered by Google App Engine
This is Rietveld 408576698