Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java

Issue 1429903005: Fix ChromeActivityTestCaseBase.loadUrlInNewTab() for document mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java
diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java
index f24d1970e886fea7c8ce51dc650403df6471aa3f..83b74d1ec34c8e2158ae345a82d1c19a956fb549 100644
--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java
+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java
@@ -355,25 +355,7 @@ public abstract class ChromeActivityTestCaseBase<T extends ChromeActivity>
* @param url The url of the page to load.
*/
public void loadUrlInNewTab(final String url) throws InterruptedException {
- // TODO(mariakhomenko): There is no current tab creator in document mode, will need
- // additional logic here for Document tests.
- if (FeatureUtilities.isDocumentMode(getInstrumentation().getContext())) {
- fail("Document mode not yet supported.");
- }
- try {
- Tab tab = ThreadUtils.runOnUiThreadBlocking(new Callable<Tab>() {
- @Override
- public Tab call() throws Exception {
- return getActivity().getCurrentTabCreator()
- .launchUrl(url, TabLaunchType.FROM_LINK);
- }
- });
-
- ChromeTabUtils.waitForTabPageLoaded(tab, url);
- getInstrumentation().waitForIdleSync();
- } catch (ExecutionException e) {
- fail("Failed to create new tab");
- }
+ loadUrlInNewTab(url, false);
}
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698