Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 14298005: Clean up isolate.gypi and use the new -V FOO=<(FOO) format. (Closed)

Created:
7 years, 8 months ago by M-A Ruel
Modified:
7 years, 8 months ago
Reviewers:
csharp
CC:
chromium-reviews, Vadim Sh.
Visibility:
Public.

Description

Clean up isolate.gypi and use the new -V FOO=<(FOO) format. This will be useful later once we start providing more variables, so that GYP do not interfere with the command line. R=csharp@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M build/isolate.gypi View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
7 years, 8 months ago (2013-04-16 20:16:53 UTC) #1
csharp
lgtm
7 years, 8 months ago (2013-04-16 20:21:18 UTC) #2
M-A Ruel
7 years, 8 months ago (2013-04-16 20:59:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r194444 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698