Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: build/isolate.gypi

Issue 14298005: Clean up isolate.gypi and use the new -V FOO=<(FOO) format. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file is meant to be included into a target to provide a rule 5 # This file is meant to be included into a target to provide a rule
6 # to "build" .isolate files into a .isolated file. 6 # to "build" .isolate files into a .isolated file.
7 # 7 #
8 # To use this, create a gyp target with the following form: 8 # To use this, create a gyp target with the following form:
9 # 'conditions': [ 9 # 'conditions': [
10 # ['test_isolation_mode != "noop"', { 10 # ['test_isolation_mode != "noop"', {
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 '<(PRODUCT_DIR)/<(RULE_INPUT_ROOT).isolated', 64 '<(PRODUCT_DIR)/<(RULE_INPUT_ROOT).isolated',
65 ], 65 ],
66 'conditions': [ 66 'conditions': [
67 ["test_isolation_outdir==''", { 67 ["test_isolation_outdir==''", {
68 'action': [ 68 'action': [
69 'python', 69 'python',
70 '<(DEPTH)/tools/swarm_client/isolate.py', 70 '<(DEPTH)/tools/swarm_client/isolate.py',
71 '<(test_isolation_mode)', 71 '<(test_isolation_mode)',
72 # GYP will eliminate duplicate arguments so '<(PRODUCT_DIR)' cannot 72 # GYP will eliminate duplicate arguments so '<(PRODUCT_DIR)' cannot
73 # be provided twice. To work around this behavior, append '/'. 73 # be provided twice. To work around this behavior, append '/'.
74 #
74 # Also have a space after <(PRODUCT_DIR) or visual studio will 75 # Also have a space after <(PRODUCT_DIR) or visual studio will
75 # escape the argument wrappping " with the \ and merge it into 76 # escape the argument wrappping " with the \ and merge it into
76 # the following arguments. 77 # the following arguments.
78 #
79 # Other variables should use the -V FOO=<(FOO) form so frequent
80 # values, like '0' or '1', aren't stripped out by GYP.
77 '--outdir', '<(PRODUCT_DIR)/ ', 81 '--outdir', '<(PRODUCT_DIR)/ ',
78 '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ', 82 '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ',
79 '--variable', 'OS', '<(OS)', 83 '--variable', 'OS=<(OS)',
80 '--result', '<@(_outputs)', 84 '--result', '<@(_outputs)',
81 '--isolate', '<(RULE_INPUT_PATH)', 85 '--isolate', '<(RULE_INPUT_PATH)',
82 ], 86 ],
83 }, { 87 }, {
84 'action': [ 88 'action': [
85 'python', 89 'python',
86 '<(DEPTH)/tools/swarm_client/isolate.py', 90 '<(DEPTH)/tools/swarm_client/isolate.py',
87 '<(test_isolation_mode)', 91 '<(test_isolation_mode)',
88 '--outdir', '<(test_isolation_outdir)', 92 '--outdir', '<(test_isolation_outdir)',
89 # Have a space after <(PRODUCT_DIR) or visual studio will 93 # See comment above.
90 # escape the argument wrappping " with the \ and merge it into
91 # the following arguments.
92 '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ', 94 '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ',
93 '--variable', 'OS', '<(OS)', 95 '--variable', 'OS=<(OS)',
94 '--result', '<@(_outputs)', 96 '--result', '<@(_outputs)',
95 '--isolate', '<(RULE_INPUT_PATH)', 97 '--isolate', '<(RULE_INPUT_PATH)',
96 ], 98 ],
97 }], 99 }],
98 ['test_isolation_fail_on_missing == 0', { 100 ['test_isolation_fail_on_missing == 0', {
99 'action': ['--ignore_broken_items'], 101 'action': ['--ignore_broken_items'],
100 }, 102 },
101 ], 103 ],
102 ], 104 ],
103 105
104 'msvs_cygwin_shell': 0, 106 'msvs_cygwin_shell': 0,
105 }, 107 },
106 ], 108 ],
107 } 109 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698