Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1429753002: ServiceWorker: Remove dead code from ServiceWorkerContextWrapper (Closed)

Created:
5 years, 1 month ago by nhiroki
Modified:
5 years, 1 month ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Remove dead code from ServiceWorkerContextWrapper These functions were introduced by [1] and all callsites were removed by [2]. [1] https://codereview.chromium.org/810583002 [2] https://codereview.chromium.org/1237353002 BUG=548977 TBR=rdevlin.cronin@chromium.org Committed: https://crrev.com/7e1ac9537e03db68908d9d877cc0810af32264d5 Cr-Commit-Position: refs/heads/master@{#357039}

Patch Set 1 #

Patch Set 2 : fix "include" dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -58 lines) Patch
M content/browser/service_worker/service_worker_context_core.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 3 chunks +0 lines, -33 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/service_worker_context.h View 3 chunks +0 lines, -18 lines 0 comments Download
M extensions/browser/service_worker_manager.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
nhiroki
PTAL, thanks!
5 years, 1 month ago (2015-10-29 07:44:38 UTC) #2
kinuko
some bots look failing!
5 years, 1 month ago (2015-10-29 07:58:06 UTC) #3
kinuko
s/!/?/
5 years, 1 month ago (2015-10-29 07:58:25 UTC) #4
nhiroki
Fixed! "include" dependency was broken... (sorry, I should have tried full-build)
5 years, 1 month ago (2015-10-29 08:13:08 UTC) #5
kinuko (google)
lgtm
5 years, 1 month ago (2015-10-29 08:53:12 UTC) #6
nhiroki
On 2015/10/29 08:53:12, kinuko (google) wrote: > lgtm another account?
5 years, 1 month ago (2015-10-29 09:03:44 UTC) #7
kinuko
lgtm.
5 years, 1 month ago (2015-10-30 02:33:04 UTC) #8
nhiroki
+rdevlin.cronin@ to TBR for extensions/browser/service_worker_manager.cc (very trivial one-line change)
5 years, 1 month ago (2015-10-30 02:56:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429753002/20001
5 years, 1 month ago (2015-10-30 02:56:41 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 03:35:18 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 03:35:54 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e1ac9537e03db68908d9d877cc0810af32264d5
Cr-Commit-Position: refs/heads/master@{#357039}

Powered by Google App Engine
This is Rietveld 408576698