Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1237353002: Remove Old ChromeOS Offline Error Page (Closed)

Created:
5 years, 5 months ago by afakhry
Modified:
5 years, 5 months ago
Reviewers:
Lei Zhang, oshima
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Old ChromeOS Offline Error Page This is not used any more and hence we're removing the dead code as a result of using the new offline error page (NetErrorHelper / neterror.html/js) in the CL here: https://codereview.chromium.org/856643002/ BUG=453054 TEST=manually Committed: https://crrev.com/82694594d352bb1816d2143c8ef57ea27e4f8c1f Cr-Commit-Position: refs/heads/master@{#338960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -706 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/chromeos/offline/offline_load_page.h View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/chromeos/offline/offline_load_page.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D chrome/browser/chromeos/offline/offline_load_page_unittest.cc View 1 chunk +0 lines, -149 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 2 chunks +0 lines, -15 lines 0 comments Download
D chrome/browser/renderer_host/offline_resource_throttle.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/renderer_host/offline_resource_throttle.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D chrome/browser/resources/chromeos/offline_net_load.html View 1 chunk +0 lines, -64 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237353002/1
5 years, 5 months ago (2015-07-15 23:11:04 UTC) #2
afakhry
oshima@chromium.org: Can you please review the removal of these files: chrome/browser/chromeos/offline/offline_load_page.h chrome/browser/chromeos/offline/offline_load_page.cc chrome/browser/chromeos/offline/offline_load_page_unittest.cc thestig@chromium.org: Can ...
5 years, 5 months ago (2015-07-15 23:27:19 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/74300)
5 years, 5 months ago (2015-07-15 23:27:48 UTC) #7
oshima
can you look into mac build failure?
5 years, 5 months ago (2015-07-15 23:32:43 UTC) #8
Lei Zhang
On 2015/07/15 23:32:43, oshima wrote: > can you look into mac build failure? The bot's ...
5 years, 5 months ago (2015-07-15 23:34:10 UTC) #9
afakhry
On 2015/07/15 23:32:43, oshima wrote: > can you look into mac build failure? I did ...
5 years, 5 months ago (2015-07-15 23:35:49 UTC) #10
Lei Zhang
lgtm with oshima's approval.
5 years, 5 months ago (2015-07-15 23:42:13 UTC) #11
oshima
lgtm
5 years, 5 months ago (2015-07-16 00:12:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237353002/1
5 years, 5 months ago (2015-07-16 00:15:42 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 00:21:48 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 00:23:05 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82694594d352bb1816d2143c8ef57ea27e4f8c1f
Cr-Commit-Position: refs/heads/master@{#338960}

Powered by Google App Engine
This is Rietveld 408576698