Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 142973008: Skip _CheckFilePermissions check on Windows (Closed)

Created:
6 years, 10 months ago by adamk
Modified:
6 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, scottmg, Nico
Visibility:
Public.

Description

Skip _CheckFilePermissions check on Windows Executable bits are wonky on Windows, so checking them doesn't get us anything and incorrectly disallows uploading of, e.g., python scripts. R=maruel@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248605

Patch Set 1 #

Patch Set 2 : Indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M PRESUBMIT.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
adamk
6 years, 10 months ago (2014-02-03 21:22:27 UTC) #1
M-A Ruel
lgtm, please add NOTRY=true in the CL description if you plan to use the CQ.
6 years, 10 months ago (2014-02-03 23:03:32 UTC) #2
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 10 months ago (2014-02-03 23:04:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/142973008/40001
6 years, 10 months ago (2014-02-03 23:07:17 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:19:23 UTC) #5
commit-bot: I haz the power
Change committed as 248605
6 years, 10 months ago (2014-02-03 23:19:25 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:19:25 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:19:25 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:19:29 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 23:19:37 UTC) #10
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698