PRESUBMIT.py - Issue 142973008: Skip _CheckFilePermissions check on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 142973008: Skip _CheckFilePermissions check on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Indentation Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index b5aefd372716fd0336a305b5d7cfcefdb2b22f90..cd5baaad74e20f1f79cd2ff7970fafbf66c616f3 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -522,6 +522,8 @@ def _CheckUnwantedDependencies(input_api, output_api):

def _CheckFilePermissions(input_api, output_api):

"""Check that all files have their permissions properly set."""

+ if input_api.platform == 'win32':

+ return []

args = [sys.executable, 'tools/checkperms/checkperms.py', '--root',

input_api.change.RepositoryRoot()]

for f in input_api.AffectedFiles():

« no previous file with comments | « no previous file | no next file » | no next file with comments »