|
|
Have a central operation status code for ServiceWorker
Could we have something like it?
We'll still need some if/switch code in each module to filter out
irrelevant status code, but having a central status code usually
makes things easier:
- less switch/case between small module boundaries
- single StatusCodeToString method for error reporting and debugging
BUG= 285976
R=alecflett@chromium.org
TBR=jam
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246832
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+184 lines, -105 lines) |
Patch |
 |
M |
content/browser/service_worker/service_worker_context_core.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
content/browser/service_worker/service_worker_context_core.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/browser/service_worker/service_worker_context_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/browser/service_worker/service_worker_dispatcher_host.h
|
View
|
1
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
content/browser/service_worker/service_worker_dispatcher_host.cc
|
View
|
1
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
content/browser/service_worker/service_worker_job_coordinator.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/service_worker/service_worker_job_coordinator.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/service_worker/service_worker_job_unittest.cc
|
View
|
1
|
32 chunks |
+48 lines, -43 lines |
0 comments
|
Download
|
 |
M |
content/browser/service_worker/service_worker_register_job.h
|
View
|
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
content/browser/service_worker/service_worker_register_job.cc
|
View
|
|
4 chunks |
+9 lines, -8 lines |
0 comments
|
Download
|
 |
M |
content/browser/service_worker/service_worker_registration_status.h
|
View
|
|
1 chunk |
+3 lines, -10 lines |
0 comments
|
Download
|
 |
M |
content/browser/service_worker/service_worker_registration_status.cc
|
View
|
|
1 chunk |
+18 lines, -14 lines |
0 comments
|
Download
|
 |
M |
content/browser/service_worker/service_worker_storage.h
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/browser/service_worker/service_worker_storage.cc
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
A |
content/common/service_worker/service_worker_status_code.h
|
View
|
|
1 chunk |
+42 lines, -0 lines |
0 comments
|
Download
|
 |
A |
content/common/service_worker/service_worker_status_code.cc
|
View
|
|
1 chunk |
+32 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/content_common.gypi
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
Total messages: 9 (0 generated)
|