Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 142973003: Have a central operation status code for ServiceWorker (Closed)

Created:
6 years, 11 months ago by kinuko
Modified:
6 years, 11 months ago
Reviewers:
michaeln, alecflett, jam
CC:
chromium-reviews, tzik, jam, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

Have a central operation status code for ServiceWorker Could we have something like it? We'll still need some if/switch code in each module to filter out irrelevant status code, but having a central status code usually makes things easier: - less switch/case between small module boundaries - single StatusCodeToString method for error reporting and debugging BUG=285976 R=alecflett@chromium.org TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246832

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -105 lines) Patch
M content/browser/service_worker/service_worker_context_core.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_job_coordinator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_job_coordinator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 1 32 chunks +48 lines, -43 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.h View 2 chunks +7 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_status.h View 1 chunk +3 lines, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_status.cc View 1 chunk +18 lines, -14 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A content/common/service_worker/service_worker_status_code.h View 1 chunk +42 lines, -0 lines 0 comments Download
A content/common/service_worker/service_worker_status_code.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kinuko
While I've been working on StartWorker patch I felt it might be easier for us ...
6 years, 11 months ago (2014-01-20 10:33:42 UTC) #1
alecflett
lgtm sounds like a great simplification
6 years, 11 months ago (2014-01-23 18:04:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/142973003/1
6 years, 11 months ago (2014-01-23 18:04:18 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=46118
6 years, 11 months ago (2014-01-23 18:28:55 UTC) #4
kinuko
Fixed build error, also TBR=jam for file addition in content/content_common.gypi
6 years, 11 months ago (2014-01-24 04:53:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/142973003/230001
6 years, 11 months ago (2014-01-24 04:58:21 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=251119
6 years, 11 months ago (2014-01-24 07:41:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/142973003/230001
6 years, 11 months ago (2014-01-24 07:57:58 UTC) #8
kinuko
6 years, 11 months ago (2014-01-24 10:25:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r246832 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698