content/browser/service_worker/service_worker_registration_status.h - Issue 142973003: Have a central operation status code for ServiceWorker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration_status.h

Issue 142973003: Have a central operation status code for ServiceWorker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_register_job.cc ('k') | content/browser/service_worker/service_worker_registration_status.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration_status.h

diff --git a/content/browser/service_worker/service_worker_registration_status.h b/content/browser/service_worker/service_worker_registration_status.h

index 1676b495cde92e82d4b1940affee6337308b7459..8cffd5628e92202d7b04f3e813f3fb8ef32d5632 100644

--- a/content/browser/service_worker/service_worker_registration_status.h

+++ b/content/browser/service_worker/service_worker_registration_status.h

@@ -6,21 +6,14 @@

#define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTRATION_STATUS_H_

#include "base/strings/string16.h"

+#include "content/common/service_worker/service_worker_status_code.h"

#include "third_party/WebKit/public/platform/WebServiceWorkerError.h"

namespace content {

-// This enum describes the reason a registration or unregistration succeeds or

-// fails.

-enum ServiceWorkerRegistrationStatus {

- REGISTRATION_OK,

- REGISTRATION_INSTALL_FAILED,

- REGISTRATION_ACTIVATE_FAILED,

-};

-// This should only be called for errors, where status != REGISTRATION_OK.

+// This should only be called for errors, where status != OK.

void GetServiceWorkerRegistrationStatusResponse(

- ServiceWorkerRegistrationStatus status,

+ ServiceWorkerStatusCode status,

blink::WebServiceWorkerError::ErrorType* error_type,

base::string16* message);