Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 14297013: Cleanup: Remove unnecessary ".get()" from scoped_ptrs<>. (Closed)

Created:
7 years, 8 months ago by Elliot Glaysher
Modified:
7 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, sadrul, dcheng, ben+watch_chromium.org, tfarina
Visibility:
Public.

Description

Cleanup: Remove unnecessary ".get()" from scoped_ptrs<>. In r174057, ajwong@ added support for implicit testing to scoped_ptr<>. Removes these in ash/. BUG=232084 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -122 lines) Patch
M ash/accelerators/accelerator_controller.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M ash/desktop_background/desktop_background_controller.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ash/desktop_background/desktop_background_widget_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/display/display_controller.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ash/display/output_configurator_animation.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/focus_cycler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/launcher/launcher_view.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ash/root_window_controller.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_widget.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shell.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M ash/system/tray/system_tray.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray_update.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/shell_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/custom_frame_view_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_window_resizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/event_rewriter_event_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/gestures/shelf_gesture_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/gestures/two_finger_drag_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/image_cursors.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/maximize_bubble_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_frame_view.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M ash/wm/screen_dimmer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/session_state_animator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/session_state_controller_impl2.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M ash/wm/window_cycle_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/frame_maximize_button.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/workspace/workspace_cycler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
This mechanical cleanup patch brought to you by git ls-files | xargs sed -i -e ...
7 years, 8 months ago (2013-04-16 21:43:34 UTC) #1
James Cook
Rubber stamp LGTM. I spot checked a few. I don't feel strongly that the .get() ...
7 years, 8 months ago (2013-04-16 21:53:09 UTC) #2
Elliot Glaysher
Committed patchset #1 manually as r194609 (presubmit successful).
7 years, 8 months ago (2013-04-17 16:47:17 UTC) #3
tfarina
7 years, 8 months ago (2013-04-17 16:53:17 UTC) #4
Message was sent while issue was closed.
Elliot, in CL description s/ajwong/enne.

Powered by Google App Engine
This is Rietveld 408576698