Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 142963002: Revert "Revert of Update of change event for input type number (https://codereview.chromium.org/128… (Closed)

Created:
6 years, 11 months ago by tkent
Modified:
6 years, 11 months ago
Reviewers:
Habib Virji, keishi
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Revert "Revert of Update of change event for input type number (https://codereview.chromium.org/128133002/)" The revert didn't help. Original issue's description: > Revert of Update of change event for input type number (https://codereview.chromium.org/128133002/) > > Reason for revert: > I'm afraid It made time-multiple-fields-spinbutton-change-and-input-events.html flaky. > > > Original issue's description: > > Do not dispatch 'change' events during pressing spin buttons for input[type=number]. > > > > TextFieldInputType sends change event for its derived class. Change is > > done for DispatchInputAndChangeEvent to behave similar to > > DispatchChangeEvent. > > DispatchChangeEvent is generated by Range, Radio, File and Checkbox > > input type. > > DispatchInputAndChangeEvent is generated by inputtype for step up and > > down, BaseChooser/BaseMultipleFieldsDateandTime also generates > > DispatchInputAndChangeEvent. > > Since it is different set of inputs that generate DispatchChange and > > DispatchInputAndChange, both are kept but behavior is changed; this > > allows spin button to handle mouseup event. > > Keyboard events are also handled for spin button. > > > > R=tkent > > BUG=155747 > > TEST=automated > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165300 > > TBR=keishi@chromium.org,habib.virji@samsung.com > NOTREECHECKS=true > NOTRY=true > BUG=155747 TBR=keishi@chromium.org,habib.virji@samsung.com NOTREECHECKS=true NOTRY=true BUG=155747 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165377

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
tkent
Committed patchset #1 manually as r165377 (presubmit successful).
6 years, 11 months ago (2014-01-20 04:37:14 UTC) #1
tkent
6 years, 10 months ago (2014-02-12 07:39:58 UTC) #2
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/159903004/ by tkent@chromium.org.

The reason for reverting is: INPUT element dispatches extra events.
.

Powered by Google App Engine
This is Rietveld 408576698