Simple Cache: DoomEntriesBetween()

net/disk_cache/simple/simple_backend_impl.h

Index: net/disk_cache/simple/simple_backend_impl.h
diff --git a/net/disk_cache/simple/simple_backend_impl.h b/net/disk_cache/simple/simple_backend_impl.h
index eab0164521d9ba12497bc4bdcfda030a2d334920..fa73568cd83ebfa1c982c583f274e06546369204 100644
--- a/net/disk_cache/simple/simple_backend_impl.h
+++ b/net/disk_cache/simple/simple_backend_impl.h
@@ -30,8 +30,8 @@ namespace disk_cache {
 // such as eviction.
 
 // See http://www.chromium.org/developers/design-documents/network-stack/disk-cache/very-simple-backend
-
-class NET_EXPORT_PRIVATE SimpleBackendImpl : public Backend {
+class NET_EXPORT_PRIVATE SimpleBackendImpl : public Backend,
+    public base::SupportsWeakPtr<SimpleBackendImpl> {

[gavinp, 2013/04/18 08:16:06]

This requires some thought. The Index can be destructed on the worker pool,
right?

Perhaps not: as long as the Backend is alive, it cannot?

Subtle.

[pasko-google - do not use, 2013/04/18 09:29:54]

It was written in the assumption that the index is always destroyed in the
backend destructor, and now it is scoped_refptr. Anyway, per offline discussion:
we can destroy the weak pointer on any thread, so destructing the callbacks
(containing the weak pointer) in the queue of callbacks with the index
destruction should be fine.

  public:
   SimpleBackendImpl(const base::FilePath& path, int max_bytes,
                     net::CacheType type,
@@ -71,6 +71,11 @@ class NET_EXPORT_PRIVATE SimpleBackendImpl : public Backend {
   // Must run on IO Thread.
   void InitializeIndex(const CompletionCallback& callback, int result);
 
+  // Dooms all entries previously accessed between |initial_time| and
+  // |end_time|. Invoked when the index is ready.
+  void IndexReadyForDoom(base::Time initial_time, base::Time end_time,

[gavinp, 2013/04/18 06:11:35]

Chromium style says these should be on separate lines.

[pasko-google - do not use, 2013/04/18 09:29:54]

Argh. Done.

+                         const CompletionCallback& callback, int result);
+
   // Try to create the directory if it doesn't exist.
   // Must run on Cache Thread.
   static void CreateDirectory(