Simple Cache: DoomEntriesBetween()

net/disk_cache/simple/simple_backend_impl.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_DISK_CACHE_SIMPLE_SIMPLE_BACKEND_IMPL_H_
 #define NET_DISK_CACHE_SIMPLE_SIMPLE_BACKEND_IMPL_H_
 
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 12 matching lines @@
 
 namespace disk_cache {
 
 // SimpleBackendImpl is a new cache backend that stores entries in individual
 // files.
 
 // It is currently a work in progress, missing many features of a real cache,
 // such as eviction.
 
 // See http://www.chromium.org/developers/design-documents/network-stack/disk-cache/very-simple-backend
-
-class NET_EXPORT_PRIVATE SimpleBackendImpl : public Backend {
+class NET_EXPORT_PRIVATE SimpleBackendImpl : public Backend,
+    public base::SupportsWeakPtr<SimpleBackendImpl> {

[gavinp, 2013/04/18 08:16:06]

This requires some thought. The Index can be destructed on the worker pool,
right?

Perhaps not: as long as the Backend is alive, it cannot?

Subtle.

[pasko-google - do not use, 2013/04/18 09:29:54]

It was written in the assumption that the index is always destroyed in the
backend destructor, and now it is scoped_refptr. Anyway, per offline discussion:
we can destroy the weak pointer on any thread, so destructing the callbacks
(containing the weak pointer) in the queue of callbacks with the index
destruction should be fine.

  public:
   SimpleBackendImpl(const base::FilePath& path, int max_bytes,
                     net::CacheType type,
                     const scoped_refptr<base::TaskRunner>& cache_thread,
                     net::NetLog* net_log);
 
   virtual ~SimpleBackendImpl();
 
   // Must run on IO Thread.
   int Init(const CompletionCallback& completion_callback);
@@ skipping 19 matching lines @@
   virtual void GetStats(
       std::vector<std::pair<std::string, std::string> >* stats) OVERRIDE;
   virtual void OnExternalCacheHit(const std::string& key) OVERRIDE;
 
  private:
   typedef base::Callback<void(int result)> InitializeIndexCallback;
 
   // Must run on IO Thread.
   void InitializeIndex(const CompletionCallback& callback, int result);
 
+  // Dooms all entries previously accessed between |initial_time| and
+  // |end_time|. Invoked when the index is ready.
+  void IndexReadyForDoom(base::Time initial_time, base::Time end_time,

[gavinp, 2013/04/18 06:11:35]

Chromium style says these should be on separate lines.

[pasko-google - do not use, 2013/04/18 09:29:54]

Argh. Done.

+                         const CompletionCallback& callback, int result);
+
   // Try to create the directory if it doesn't exist.
   // Must run on Cache Thread.
   static void CreateDirectory(
       base::MessageLoopProxy* io_thread,
       const base::FilePath& path,
       const InitializeIndexCallback& initialize_index_callback);
 
   const base::FilePath path_;
   scoped_refptr<SimpleIndex> index_;
   const scoped_refptr<base::TaskRunner> cache_thread_;
 };
 
 }  // namespace disk_cache
 
 #endif  // NET_DISK_CACHE_SIMPLE_SIMPLE_BACKEND_IMPL_H_