Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: chrome/browser/chromeos/drive/change_list_loader.h

Issue 14292002: drive: Minor cleanup around ChangeListLoader::LoadFromServerIfNeeded() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/change_list_loader.h
diff --git a/chrome/browser/chromeos/drive/change_list_loader.h b/chrome/browser/chromeos/drive/change_list_loader.h
index 1da7d7ebbb333289e52d0735fe21d95515ca527f..201745c416f19149624c7a9f97cadb9ae65b701f 100644
--- a/chrome/browser/chromeos/drive/change_list_loader.h
+++ b/chrome/browser/chromeos/drive/change_list_loader.h
@@ -88,13 +88,9 @@ class ChangeListLoader {
const GURL& next_feed,
const LoadFeedListCallback& callback);
- // Initiates the change list loading from the server if the local
- // changestamp is older than the server changestamp.
- // See the comment at Load() for |directory_fetch_info| parameter.
- // |callback| must not be null.
- // TODO(satorux): make this private. crbug.com/193417
- void LoadFromServerIfNeeded(const DirectoryFetchInfo& directory_fetch_info,
- const FileOperationCallback& callback);
+ // Checks for updates on the server. Does nothing if the change list is now
+ // being loaded or refreshed. |callback| must not be null.
+ void CheckForUpdates(const FileOperationCallback& callback);
// Updates whole directory structure feeds collected in |feed_list|.
// Record file statistics as UMA histograms.
@@ -111,6 +107,13 @@ class ChangeListLoader {
bool refreshing() const { return refreshing_; }
private:
+ // Initiates the change list loading from the server if the local
+ // changestamp is older than the server changestamp.
+ // See the comment at Load() for |directory_fetch_info| parameter.
+ // |callback| must not be null.
+ void LoadFromServerIfNeeded(const DirectoryFetchInfo& directory_fetch_info,
+ const FileOperationCallback& callback);
+
// Checks the local changestamp. |callback| must not be null.
void CheckLocalChangestamp(const GetChangestampCallback& callback);
« no previous file with comments | « no previous file | chrome/browser/chromeos/drive/change_list_loader.cc » ('j') | chrome/browser/chromeos/drive/drive_file_system.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698