drive: Minor cleanup around ChangeListLoader::LoadFromServerIfNeeded()

chrome/browser/chromeos/drive/drive_file_system.cc

Index: chrome/browser/chromeos/drive/drive_file_system.cc
diff --git a/chrome/browser/chromeos/drive/drive_file_system.cc b/chrome/browser/chromeos/drive/drive_file_system.cc
index b7c8eacd017d4553c41ed410147efa3cf9a35e1b..b1f7ab54e5f8257c8412d00793e91566d9dc3314 100644
--- a/chrome/browser/chromeos/drive/drive_file_system.cc
+++ b/chrome/browser/chromeos/drive/drive_file_system.cc
@@ -257,7 +257,7 @@ void DriveFileSystem::Initialize() {
 void DriveFileSystem::ReloadAfterReset() {
   SetupChangeListLoader();
 
-  change_list_loader_->LoadFromServerIfNeeded(
+  change_list_loader_->LoadIfNeeded(

[kinaba, 2013/04/16 08:54:28]

Reload() is, at least originally, meant to be a feature
that discards the local metadata cache and reloads full
feed from the server. (That's why Load<FromServer>IfNeeded
is used here.)

But it is actually already broken already, since
LoadFromServerIfNeeded automatically respects the cache
timestamp (after we switched to level DB).

Probably we should just abandon DriveSystemService::ReloadAndRemountFileSystem.

       DirectoryFetchInfo(),
       base::Bind(&DriveFileSystem::OnUpdateChecked,
                  weak_ptr_factory_.GetWeakPtr()));
@@ -272,14 +272,10 @@ void DriveFileSystem::SetupChangeListLoader() {
 
 void DriveFileSystem::CheckForUpdates() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   DVLOG(1) << "CheckForUpdates";
 
-  if (change_list_loader_ &&
-      change_list_loader_->loaded() &&
-      !change_list_loader_->refreshing()) {
-    change_list_loader_->LoadFromServerIfNeeded(
-        DirectoryFetchInfo(),
+  if (change_list_loader_) {
+    change_list_loader_->CheckForUpdates(
         base::Bind(&DriveFileSystem::OnUpdateChecked,
                    weak_ptr_factory_.GetWeakPtr()));
   }