Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: blimp/engine/browser/blimp_engine_session.h

Issue 1429193002: Add interfaces for most major Blimp net components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address wez's feedback. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/browser/blimp_engine_session.h
diff --git a/blimp/engine/browser/blimp_engine_session.h b/blimp/engine/browser/blimp_engine_session.h
index 46b30391906c78d21510d6d00ec692158568521b..55192bcbbd6e6c65465df4d68195bda8e4d8acf2 100644
--- a/blimp/engine/browser/blimp_engine_session.h
+++ b/blimp/engine/browser/blimp_engine_session.h
@@ -7,8 +7,9 @@
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
-#include "blimp/net/blimp_message_receiver.h"
+#include "blimp/net/blimp_message_processor.h"
#include "content/public/browser/web_contents_delegate.h"
+#include "net/base/net_errors.h"
Wez 2015/11/12 03:45:56 Why are you including this?
Kevin M 2015/11/12 19:03:47 Done.
#include "ui/gfx/geometry/size.h"
namespace aura {
@@ -42,7 +43,7 @@ class BlimpScreen;
class BlimpUiContextFactory;
class BlimpWindowTreeHost;
-class BlimpEngineSession : public BlimpMessageReceiver,
+class BlimpEngineSession : public BlimpMessageProcessor,
public content::WebContentsDelegate {
public:
explicit BlimpEngineSession(scoped_ptr<BlimpBrowserContext> browser_context);
@@ -52,9 +53,10 @@ class BlimpEngineSession : public BlimpMessageReceiver,
BlimpBrowserContext* browser_context() { return browser_context_.get(); }
- // BlimpMessageReceiver implementation.
- // TODO(haibinlu): Remove this in favor of the BlimpMessageDispatcher.
- net::Error OnBlimpMessage(const BlimpMessage& message) override;
+ // BlimpMessageProcessor implementation.
+ // TODO(haibinlu): Delete this and move to BlimpMessageDemultiplexer.
+ void ProcessMessage(const BlimpMessage& message,
+ const net::CompletionCallback& callback) override;
Wez 2015/11/12 03:45:56 include net/completion_callback for this, or forwa
Kevin M 2015/11/12 19:03:47 Done.
private:
// Creates a new WebContents, which will be indexed by |target_tab_id|.

Powered by Google App Engine
This is Rietveld 408576698