Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: blimp/engine/browser/blimp_engine_session.cc

Issue 1429193002: Add interfaces for most major Blimp net components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address wez's feedback. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/browser/blimp_engine_session.cc
diff --git a/blimp/engine/browser/blimp_engine_session.cc b/blimp/engine/browser/blimp_engine_session.cc
index 6ffd79dabdbee355d0383aee2861d41584e3e79d..81fc05ff4d4944cd8e3d57cd9231951a5bf44fdc 100644
--- a/blimp/engine/browser/blimp_engine_session.cc
+++ b/blimp/engine/browser/blimp_engine_session.cc
@@ -17,6 +17,7 @@
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/render_widget_host.h"
#include "content/public/browser/web_contents.h"
+#include "net/base/net_errors.h"
#include "ui/aura/client/default_capture_client.h"
#include "ui/aura/env.h"
#include "ui/aura/window.h"
@@ -107,7 +108,9 @@ void BlimpEngineSession::LoadUrl(const int target_tab_id, const GURL& url) {
web_contents_->Focus();
}
-net::Error BlimpEngineSession::OnBlimpMessage(const BlimpMessage& message) {
+void BlimpEngineSession::ProcessMessage(
+ const BlimpMessage& message,
+ const net::CompletionCallback& callback) {
DCHECK(message.type() == BlimpMessage::CONTROL);
switch (message.control().type()) {
@@ -122,7 +125,7 @@ net::Error BlimpEngineSession::OnBlimpMessage(const BlimpMessage& message) {
NOTIMPLEMENTED();
}
- return net::OK;
+ callback.Run(net::OK);
Wez 2015/11/12 03:45:56 Didn't we agree that ProcessMessage should be requ
Kevin M 2015/11/12 19:03:47 Done.
}
void BlimpEngineSession::AddNewContents(content::WebContents* source,

Powered by Google App Engine
This is Rietveld 408576698