Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1429003002: Add SDIV to ARM integrated assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -12 lines) Patch
M src/DartARM32/assembler_arm.h View 3 chunks +10 lines, -6 lines 0 comments Download
M src/DartARM32/assembler_arm.cc View 6 chunks +9 lines, -6 lines 0 comments Download
M src/IceAssemblerARM32.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 4 chunks +48 lines, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
A tests_lit/assembler/arm32/sdiv.ll View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Karl
5 years, 1 month ago (2015-10-30 17:37:15 UTC) #3
Jim Stichnoth
lgtm
5 years, 1 month ago (2015-10-30 19:07:14 UTC) #4
Karl
5 years, 1 month ago (2015-10-30 20:22:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
697dc7966c9827f5cdac9f752351cb90e7bf00d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698