Utilize ProfileInfoCache to support data type counts in profile deletion flow

chrome/browser/profiles/profile_statistics.h

Index: chrome/browser/profiles/profile_statistics.h
diff --git a/chrome/browser/profiles/profile_statistics.h b/chrome/browser/profiles/profile_statistics.h
index 61bba0d7c93cc61d941e1d3bf5180d7be1e695ca..d65713f3d58114415b10c49e59537098ff808b45 100644
--- a/chrome/browser/profiles/profile_statistics.h
+++ b/chrome/browser/profiles/profile_statistics.h
@@ -42,11 +42,16 @@ using ProfileStatisticsCallback = base::Callback<void(ProfileCategoryStats)>;
 // This function collects statistical information about |profile| and returns
 // the information via |callback|. Currently bookmarks, history, logins and
 // preferences are counted. The callback function will probably be called more
-// than once so binding parameters with bind::Passed() is prohibited.
+// than once so binding parameters with bind::Passed() is prohibited. The
+// statistical information are also copied to ProfileInfoCache.
 void GetProfileStatistics(Profile* profile,
                           const ProfileStatisticsCallback& callback,
                           base::CancelableTaskTracker* tracker);
 
+// This function collects statistical information about |profile| and sends the
+// information to ProfileInfoCache.

[Mike Lerman, 2015/11/26 15:06:25]

nit: to the ProfileInfoCache

[lwchkg, 2015/12/02 15:33:34]

Acknowledged.

+void StoreProfileStatisticsToCache(Profile* profile);

[Mike Lerman, 2015/11/26 15:06:25]

Why is this method really needed? Can't I just call GetProfileStatistics and
pass null or placeholder values for the two other parameters?

This method seems odd from an API perspective. Just something to consider.

[lwchkg, 2015/12/02 15:33:34]

Calling GetProfileStatistics to store the statistics is of course possible, but
the name of that function looks confusing in the call site, as the intent of the
call is not to "get profile statistics". So I've made
StoreProfileStatisticsToCache to make the code more readable. WDYT?

[Mike Lerman, 2015/12/07 16:21:20]

You could rename GetProfileStatistics to GatherProfileStatistics. Get really is
a bit of a misnomer since it doesn't return anything, at best it executes a
callback that gets passed the information.

[lwchkg, 2015/12/09 03:39:41]

Brilliant idea! Problem solved. And now I finally understand why Anthony say
that you're excellent in naming.

+
 // ProfileInfoCache ------------------------------------------------------------
 
 // Gets statistical information from ProfileInfoCache.