Utilize ProfileInfoCache to support data type counts in profile deletion flow

chrome/browser/profiles/profile_statistics.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_STATISTICS_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_STATISTICS_H_
 
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 24 matching lines @@
 
 // Definition of the callback function. Note that a copy of
 // |ProfileCategoryStats| is made each time the callback is called.
 using ProfileStatisticsCallback = base::Callback<void(ProfileCategoryStats)>;
 
 // Profile Statistics ----------------------------------------------------------
 
 // This function collects statistical information about |profile| and returns
 // the information via |callback|. Currently bookmarks, history, logins and
 // preferences are counted. The callback function will probably be called more
-// than once so binding parameters with bind::Passed() is prohibited.
+// than once so binding parameters with bind::Passed() is prohibited. The
+// statistical information are also copied to ProfileInfoCache.
 void GetProfileStatistics(Profile* profile,
                           const ProfileStatisticsCallback& callback,
                           base::CancelableTaskTracker* tracker);
 
+// This function collects statistical information about |profile| and sends the
+// information to ProfileInfoCache.

[Mike Lerman, 2015/11/26 15:06:25]

nit: to the ProfileInfoCache

[lwchkg, 2015/12/02 15:33:34]

Acknowledged.

+void StoreProfileStatisticsToCache(Profile* profile);

[Mike Lerman, 2015/11/26 15:06:25]

Why is this method really needed? Can't I just call GetProfileStatistics and
pass null or placeholder values for the two other parameters?

This method seems odd from an API perspective. Just something to consider.

[lwchkg, 2015/12/02 15:33:34]

Calling GetProfileStatistics to store the statistics is of course possible, but
the name of that function looks confusing in the call site, as the intent of the
call is not to "get profile statistics". So I've made
StoreProfileStatisticsToCache to make the code more readable. WDYT?

[Mike Lerman, 2015/12/07 16:21:20]

You could rename GetProfileStatistics to GatherProfileStatistics. Get really is
a bit of a misnomer since it doesn't return anything, at best it executes a
callback that gets passed the information.

[lwchkg, 2015/12/09 03:39:41]

Brilliant idea! Problem solved. And now I finally understand why Anthony say
that you're excellent in naming.

+
 // ProfileInfoCache ------------------------------------------------------------
 
 // Gets statistical information from ProfileInfoCache.
 ProfileCategoryStats GetProfileStatisticsFromCache(
     const base::FilePath& profile_path);
 
 // Sets an individual statistic to ProfileInfoCache.
 void SetProfileStatisticsInCache(const base::FilePath& profile_path,
                                  const std::string& category, int count);
 
 }  // namespace profiles
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_STATISTICS_H_