Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 1428753010: Add unit tests for CdmAdapter (Closed)

Created:
5 years, 1 month ago by jrummell
Modified:
5 years, 1 month ago
Reviewers:
xhwang
CC:
chromium-reviews, eme-reviews_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unit tests for CdmAdapter BUG=510088 TEST=new unittests pass Committed: https://crrev.com/30996193fe3e69fe9ccd52471900bf5685c54956 Cr-Commit-Position: refs/heads/master@{#359582}

Patch Set 1 #

Patch Set 2 : more tests #

Total comments: 8

Patch Set 3 : test changes #

Total comments: 2

Patch Set 4 : rename enum #

Patch Set 5 : changes for bots #

Total comments: 4

Patch Set 6 : inline GURL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -14 lines) Patch
M media/BUILD.gn View 1 2 3 4 5 2 chunks +7 lines, -1 line 0 comments Download
M media/cdm/aes_decryptor.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
A media/cdm/cdm_adapter_unittest.cc View 1 2 3 4 1 chunk +374 lines, -0 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 1 2 3 4 5 2 chunks +4 lines, -11 lines 0 comments Download
M media/media.gyp View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (5 generated)
jrummell
PTAL
5 years, 1 month ago (2015-11-05 22:42:21 UTC) #2
xhwang
I'll wait for the other CL to review this. Does it make sense to try ...
5 years, 1 month ago (2015-11-05 23:25:51 UTC) #3
jrummell
Updated to add new tests, and rebase on the Create() changes. As for using AesDecryptor ...
5 years, 1 month ago (2015-11-07 00:44:51 UTC) #4
xhwang
looking pretty good. I just have a few comments. https://chromiumcodereview.appspot.com/1428753010/diff/20001/media/cdm/cdm_adapter_unittest.cc File media/cdm/cdm_adapter_unittest.cc (right): https://chromiumcodereview.appspot.com/1428753010/diff/20001/media/cdm/cdm_adapter_unittest.cc#newcode94 media/cdm/cdm_adapter_unittest.cc:94: ...
5 years, 1 month ago (2015-11-10 22:58:58 UTC) #5
jrummell
Updated. https://codereview.chromium.org/1428753010/diff/20001/media/cdm/cdm_adapter_unittest.cc File media/cdm/cdm_adapter_unittest.cc (right): https://codereview.chromium.org/1428753010/diff/20001/media/cdm/cdm_adapter_unittest.cc#newcode94 media/cdm/cdm_adapter_unittest.cc:94: ~CdmAdapterTest() override { DeinitializeCdm(); } On 2015/11/10 22:58:58, ...
5 years, 1 month ago (2015-11-12 02:30:32 UTC) #6
xhwang
LGTM with one last naming nit. Thanks! https://chromiumcodereview.appspot.com/1428753010/diff/40001/media/cdm/cdm_adapter_unittest.cc File media/cdm/cdm_adapter_unittest.cc (right): https://chromiumcodereview.appspot.com/1428753010/diff/40001/media/cdm/cdm_adapter_unittest.cc#newcode91 media/cdm/cdm_adapter_unittest.cc:91: enum PromiseResult ...
5 years, 1 month ago (2015-11-12 06:20:36 UTC) #7
jrummell
Thanks for the reviews. https://codereview.chromium.org/1428753010/diff/40001/media/cdm/cdm_adapter_unittest.cc File media/cdm/cdm_adapter_unittest.cc (right): https://codereview.chromium.org/1428753010/diff/40001/media/cdm/cdm_adapter_unittest.cc#newcode91 media/cdm/cdm_adapter_unittest.cc:91: enum PromiseResult { SUCCESS, FAILURE ...
5 years, 1 month ago (2015-11-12 17:56:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428753010/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428753010/60001
5 years, 1 month ago (2015-11-12 17:57:34 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/143839) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 1 month ago (2015-11-12 18:05:07 UTC) #13
jrummell
xhwang@, please take another look. Changes for avoiding memory leak with GURL::EmptyGURL(), as well as ...
5 years, 1 month ago (2015-11-12 23:23:35 UTC) #14
xhwang
https://codereview.chromium.org/1428753010/diff/80001/media/cdm/aes_decryptor.cc File media/cdm/aes_decryptor.cc (right): https://codereview.chromium.org/1428753010/diff/80001/media/cdm/aes_decryptor.cc#newcode315 media/cdm/aes_decryptor.cc:315: *empty_gurl_.get()); Can we just create a local one here? ...
5 years, 1 month ago (2015-11-13 00:03:22 UTC) #15
jrummell
Updated. https://codereview.chromium.org/1428753010/diff/80001/media/cdm/aes_decryptor.cc File media/cdm/aes_decryptor.cc (right): https://codereview.chromium.org/1428753010/diff/80001/media/cdm/aes_decryptor.cc#newcode315 media/cdm/aes_decryptor.cc:315: *empty_gurl_.get()); On 2015/11/13 00:03:22, xhwang wrote: > Can ...
5 years, 1 month ago (2015-11-13 00:35:21 UTC) #16
xhwang
LGTM++
5 years, 1 month ago (2015-11-13 01:04:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428753010/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428753010/100001
5 years, 1 month ago (2015-11-13 18:02:12 UTC) #19
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 1 month ago (2015-11-13 18:06:59 UTC) #20
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/30996193fe3e69fe9ccd52471900bf5685c54956 Cr-Commit-Position: refs/heads/master@{#359582}
5 years, 1 month ago (2015-11-13 18:07:41 UTC) #21
zhaoqin
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/1450803002/ by zhaoqin@google.com. ...
5 years, 1 month ago (2015-11-16 03:37:49 UTC) #22
zhaoqin1
5 years, 1 month ago (2015-11-16 03:45:05 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1447943002/ by zhaoqin@chromium.org.

The reason for reverting is: valgrind reports leaks with no-debug-symbol
callstack

BUG=556346
TBR=jrummell@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698