Add unit tests for CdmAdapter

media/cdm/aes_decryptor.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cdm/aes_decryptor.h"
 
 #include <list>
 #include <vector>
 
 #include "base/logging.h"
@@ skipping 216 matching lines @@
                  output->writable_data());
   return output;
 }
 
 AesDecryptor::AesDecryptor(const GURL& /* security_origin */,
                            const SessionMessageCB& session_message_cb,
                            const SessionClosedCB& session_closed_cb,
                            const SessionKeysChangeCB& session_keys_change_cb)
     : session_message_cb_(session_message_cb),
       session_closed_cb_(session_closed_cb),
-      session_keys_change_cb_(session_keys_change_cb) {
+      session_keys_change_cb_(session_keys_change_cb),
+      empty_gurl_(new GURL()) {
   // AesDecryptor doesn't keep any persistent data, so no need to do anything
   // with |security_origin|.
   DCHECK(!session_message_cb_.is_null());
   DCHECK(!session_closed_cb_.is_null());
   DCHECK(!session_keys_change_cb_.is_null());
+  DCHECK(empty_gurl_->is_empty());
 }
 
 AesDecryptor::~AesDecryptor() {
   key_map_.clear();
 }
 
 void AesDecryptor::SetServerCertificate(const std::vector<uint8_t>& certificate,
                                         scoped_ptr<SimpleCdmPromise> promise) {
   promise->reject(
       NOT_SUPPORTED_ERROR, 0, "SetServerCertificate() is not supported.");
@@ skipping 50 matching lines @@
                         "init_data_type not supported.");
         return;
     }
     CreateLicenseRequest(keys, session_type, &message);
   }
 
   promise->resolve(session_id);
 
   // No URL needed for license requests.
   session_message_cb_.Run(session_id, LICENSE_REQUEST, message,
-                          GURL::EmptyGURL());
+                          *empty_gurl_.get());

[xhwang, 2015/11/13 00:03:22]

Can we just create a local one here?

GURL empty_gurl;
session_message_cb_.Run(session_id, LICENSE_REQUEST, message, empty_gurl);

[jrummell, 2015/11/13 00:35:20]

Done.

 }
 
 void AesDecryptor::LoadSession(SessionType session_type,
                                const std::string& session_id,
                                scoped_ptr<NewSessionCdmPromise> promise) {
   // TODO(xhwang): Change this to NOTREACHED() when blink checks for key systems
   // that do not support loadSession. See http://crbug.com/342481
   promise->reject(NOT_SUPPORTED_ERROR, 0, "LoadSession() is not supported.");
 }
 
@@ skipping 280 matching lines @@
 bool AesDecryptor::DecryptionKey::Init() {
   CHECK(!secret_.empty());
   decryption_key_.reset(crypto::SymmetricKey::Import(
       crypto::SymmetricKey::AES, secret_));
   if (!decryption_key_)
     return false;
   return true;
 }
 
 }  // namespace media