tools/telemetry/telemetry/internal/actions/action_runner_unittest.py - Issue 1428733002: Update telemetry tests to be agnostic to ScrollTopLeftInterop mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/actions/action_runner_unittest.py

Issue 1428733002: Update telemetry tests to be agnostic to ScrollTopLeftInterop mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/internal/actions/action_runner_unittest.py

diff --git a/tools/telemetry/telemetry/internal/actions/action_runner_unittest.py b/tools/telemetry/telemetry/internal/actions/action_runner_unittest.py

index 8ddd1f4f0b7872ae5f9368fbff3c78780ebdaa5f..99a00bd2290ec74162622061f7a4325410f34abd 100644

--- a/tools/telemetry/telemetry/internal/actions/action_runner_unittest.py

+++ b/tools/telemetry/telemetry/internal/actions/action_runner_unittest.py

@@ -229,7 +229,7 @@ class ActionRunnerTest(tab_test_case.TabTestCase):

action_runner.ScrollPage(direction='right', left_start_ratio=0.9,

distance=100)

self.assertTrue(action_runner.EvaluateJavaScript(

- 'document.body.scrollLeft') > 75)

+ 'document.scrollingElement.scrollLeft') > 75)

@decorators.Disabled('android', # crbug.com/437065.

'chromeos') # crbug.com/483212.

@@ -253,7 +253,7 @@ class ActionRunnerTest(tab_test_case.TabTestCase):

action_runner.SwipePage(direction='left', left_start_ratio=0.9)

self.assertTrue(action_runner.EvaluateJavaScript(

- 'document.body.scrollLeft') > 75)

+ 'document.scrollingElement.scrollLeft') > 75)

class InteractionTest(unittest.TestCase):

« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/actions/scroll.js » ('j') | no next file with comments »