Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1428673002: Minor refactor of ExclusiveAccessView (fullscreen info bubble). (Closed)

Created:
5 years, 1 month ago by Matt Giuca
Modified:
5 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@exclusiveaccess-opacity
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor refactor of ExclusiveAccessView (fullscreen info bubble). - Reordered class fields so they have the same order as they are inserted into the Views hierarchy. - More detailed descriptions of views, including whether views are present in simplified / non-simplified modes. - Renamed mouse_lock_exit_instruction_ to exit_instruction_. (It also shows exit instructions for fullscreen.) BUG=352425 Committed: https://crrev.com/7de7140fee31af3b23cf445ffda771f820bd1708 Cr-Commit-Position: refs/heads/master@{#356714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M chrome/browser/ui/views/exclusive_access_bubble_views.cc View 6 chunks +16 lines, -12 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Matt Giuca
5 years, 1 month ago (2015-10-28 03:13:17 UTC) #2
msw
lgtm
5 years, 1 month ago (2015-10-28 17:37:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428673002/1
5 years, 1 month ago (2015-10-28 23:53:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 00:57:39 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 00:58:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7de7140fee31af3b23cf445ffda771f820bd1708
Cr-Commit-Position: refs/heads/master@{#356714}

Powered by Google App Engine
This is Rietveld 408576698