Made fullscreen bubble text non-transparent.

Made fullscreen bubble text non-transparent.

Now the background and text are on separate layers, so we have a
transparent background with fully opaque text.

BUG=352425
Committed: https://crrev.com/7ebc49b160c2a26750a1677d207f01d93aac24a8
Cr-Commit-Position: refs/heads/master@{#356508}

[Matt Giuca, 2015-10-21 03:35:53]

Description was changed from

==========
Made fullscreen bubble text non-transparent.

Now the background and text are on separate layers, so we have a
transparent background with fully opaque text.

BUG=352509
==========

to

==========
Made fullscreen bubble text non-transparent.

Now the background and text are on separate layers, so we have a
transparent background with fully opaque text.

BUG=352509
==========

[Matt Giuca, 2015-10-21 06:37:16]

mgiuca@chromium.org changed reviewers:
+ msw@chromium.org

[Matt Giuca, 2015-10-21 06:37:17]

msw: Please review (not urgent; I won't be around to respond to comments until
Monday).

[msw, 2015-10-22 22:03:44]

https://codereview.chromium.org/1413523003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/exclusive_access_bubble_views.cc (right):

https://codereview.chromium.org/1413523003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/exclusive_access_bubble_views.cc:121: views::View*
background_;
Why do we need new container views to set the opacity? Can't we just set the
Bubble[Border|Background] colors with the desired opacity and make this view
paint to a layer that doesn't fill the bounds opaquely?

https://codereview.chromium.org/1413523003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/exclusive_access_bubble_views.cc:244:
background_->SetPaintToLayer(true);
Shouldn't these values be contingent on the new UI?

[Matt Giuca, 2015-10-26 03:10:39]

https://codereview.chromium.org/1413523003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/exclusive_access_bubble_views.cc (right):

https://codereview.chromium.org/1413523003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/exclusive_access_bubble_views.cc:121: views::View*
background_;
O_o why didn't I think of that?

Thanks, fixed.

Also this prompted me to fix the border; now it uses NO_ASSETS so it is a solid
edge rather than a soft black edge. See
https://code.google.com/p/chromium/issues/detail?id=352425#c89 for comparison
shots.

https://codereview.chromium.org/1413523003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/exclusive_access_bubble_views.cc:244:
background_->SetPaintToLayer(true);
N/A

[msw, 2015-10-26 16:53:39]

https://codereview.chromium.org/1413523003/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/exclusive_access_bubble_views.cc (right):

https://codereview.chromium.org/1413523003/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/exclusive_access_bubble_views.cc:47: // Opacity of the
background (out of 25). Only used with
"out of 255"?

https://codereview.chromium.org/1413523003/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/exclusive_access_bubble_views.cc:152: ?
SkColorSetARGBMacro(kBackgroundOpacity, 0, 0, 0)
SkColorSetA would let you still use SK_ColorBLACK.

[Matt Giuca, 2015-10-26 23:25:39]

Thanks!

https://codereview.chromium.org/1413523003/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/exclusive_access_bubble_views.cc (right):

https://codereview.chromium.org/1413523003/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/exclusive_access_bubble_views.cc:47: // Opacity of the
background (out of 25). Only used with
On 2015/10/26 16:53:39, msw wrote:
> "out of 255"?

Done.

https://codereview.chromium.org/1413523003/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/exclusive_access_bubble_views.cc:152: ?
SkColorSetARGBMacro(kBackgroundOpacity, 0, 0, 0)
On 2015/10/26 16:53:39, msw wrote:
> SkColorSetA would let you still use SK_ColorBLACK.

Done.

[msw, 2015-10-26 23:28:02]

lgtm

[Matt Giuca, 2015-10-28 02:59:29]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-10-28 02:59:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413523003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413523003/80001

[commit-bot: I haz the power, 2015-10-28 03:57:18]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-10-28 03:58:12]

Patchset 5 (id:??) landed as
https://crrev.com/7ebc49b160c2a26750a1677d207f01d93aac24a8
Cr-Commit-Position: refs/heads/master@{#356508}

[Matt Giuca, 2015-10-29 02:35:25]

Description was changed from

==========
Made fullscreen bubble text non-transparent.

Now the background and text are on separate layers, so we have a
transparent background with fully opaque text.

BUG=352509

Committed: https://crrev.com/7ebc49b160c2a26750a1677d207f01d93aac24a8
Cr-Commit-Position: refs/heads/master@{#356508}
==========

to

==========
Made fullscreen bubble text non-transparent.

Now the background and text are on separate layers, so we have a
transparent background with fully opaque text.

BUG=352425

Committed: https://crrev.com/7ebc49b160c2a26750a1677d207f01d93aac24a8
Cr-Commit-Position: refs/heads/master@{#356508}
==========