Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 1428643004: Repaint on interest rect change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@EnableSyncPaint
Patch Set: Copy display_list_recording_source unit tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.h
diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h
index 48e39bf1056e4bdc36aa9e033567d38452f788fd..cadd5cd3a620dd09cf2692825a03809e2e7db7df 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.h
+++ b/third_party/WebKit/Source/core/frame/FrameView.h
@@ -232,8 +232,7 @@ public:
// Run all needed lifecycle stages. After calling this method, all frames will be in the lifecycle state PaintInvalidationClean.
// If lifecycle throttling is allowed (see DocumentLifecycle::PreventThrottlingScope), some frames may skip the lifecycle update
// (e.g., based on visibility) and will not end up being PaintInvalidationClean.
- // TODO(pdr): Update callers to pass in the interest rect.
- void updateAllLifecyclePhases(const LayoutRect* interestRect = nullptr);
+ void updateAllLifecyclePhases(const IntRect* interestRect = nullptr);
chrishtr 2015/10/29 17:21:30 Will there be any non-testing use case for passing
Xianzhu 2015/10/29 18:31:28 Done.
// Computes the style, layout and compositing lifecycle stages if needed. After calling this method, all frames wil lbe in a lifecycle
// state >= CompositingClean, and scrolling has been updated (unless throttling is allowed).
@@ -632,13 +631,13 @@ private:
AllPhases,
};
- void updateLifecyclePhasesInternal(LifeCycleUpdateOption, const LayoutRect* interestRect);
+ void updateLifecyclePhasesInternal(LifeCycleUpdateOption, const IntRect* interestRect);
void invalidateTreeIfNeededRecursive();
void scrollContentsIfNeededRecursive();
void updateStyleAndLayoutIfNeededRecursive();
void updatePaintProperties();
- void synchronizedPaint(const LayoutRect* interestRect);
- void synchronizedPaintRecursively(GraphicsLayer*, const LayoutRect* interestRect);
+ void synchronizedPaint(const IntRect* interestRect);
+ void synchronizedPaintRecursively(GraphicsLayer*, const IntRect* interestRect);
void compositeForSlimmingPaintV2();
void reset();
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698