Repaint on interest rect change

third_party/WebKit/Source/core/frame/FrameView.h

 /*
    Copyright (C) 1997 Martin Jones (mjones@kde.org)
              (C) 1998 Waldo Bastian (bastian@kde.org)
              (C) 1998, 1999 Torben Weis (weis@kde.org)
              (C) 1999 Lars Knoll (knoll@kde.org)
              (C) 1999 Antti Koivisto (koivisto@kde.org)
    Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
 
    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Library General Public
@@ skipping 214 matching lines @@
     bool isPainting() const;
 
     void setNodeToDraw(Node*);
     Node* nodeToDraw() const { return m_nodeToDraw.get(); }
 
     Color documentBackgroundColor() const;
 
     // Run all needed lifecycle stages. After calling this method, all frames will be in the lifecycle state PaintInvalidationClean.
     // If lifecycle throttling is allowed (see DocumentLifecycle::PreventThrottlingScope), some frames may skip the lifecycle update
     // (e.g., based on visibility) and will not end up being PaintInvalidationClean.
-    // TODO(pdr): Update callers to pass in the interest rect.
-    void updateAllLifecyclePhases(const LayoutRect* interestRect = nullptr);
+    void updateAllLifecyclePhases(const IntRect* interestRect = nullptr);

[chrishtr, 2015/10/29 17:21:30]

Will there be any non-testing use case for passing an interest rect here?
If not, we should find a way to test without this.

[Xianzhu, 2015/10/29 18:31:28]

Done.

 
     // Computes the style, layout and compositing lifecycle stages if needed. After calling this method, all frames wil lbe in a lifecycle
     // state >= CompositingClean, and scrolling has been updated (unless throttling is allowed).
     void updateLifecycleToCompositingCleanPlusScrolling();
 
     // Computes only the style and layout lifecycle stages.
     // After calling this method, all frames will be in a lifecycle state >= LayoutClean (unless throttling is allowed).
     void updateLifecycleToLayoutClean();
 
     bool invalidateViewportConstrainedObjects();
@@ skipping 378 matching lines @@
 
     void setScrollOffset(const IntPoint&, ScrollType) override;
     void setScrollOffset(const DoublePoint&, ScrollType) override;
 
     enum LifeCycleUpdateOption {
         OnlyUpToLayoutClean,
         OnlyUpToCompositingCleanPlusScrolling,
         AllPhases,
     };
 
-    void updateLifecyclePhasesInternal(LifeCycleUpdateOption, const LayoutRect* interestRect);
+    void updateLifecyclePhasesInternal(LifeCycleUpdateOption, const IntRect* interestRect);
     void invalidateTreeIfNeededRecursive();
     void scrollContentsIfNeededRecursive();
     void updateStyleAndLayoutIfNeededRecursive();
     void updatePaintProperties();
-    void synchronizedPaint(const LayoutRect* interestRect);
-    void synchronizedPaintRecursively(GraphicsLayer*, const LayoutRect* interestRect);
+    void synchronizedPaint(const IntRect* interestRect);
+    void synchronizedPaintRecursively(GraphicsLayer*, const IntRect* interestRect);
     void compositeForSlimmingPaintV2();
 
     void reset();
     void init();
 
     void clearLayoutSubtreeRootsAndMarkContainingBlocks();
 
     // Called when our frame rect changes (or the rect/scroll position of an ancestor changes).
     void frameRectsChanged() override;
 
@@ skipping 253 matching lines @@
     static const unsigned visualPixelThreshold = 32 * 32;
     if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
         setIsVisuallyNonEmpty();
 }
 
 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFrameView());
 
 } // namespace blink
 
 #endif // FrameView_h