Do not need to find depot_tools and run GN when GYP_GENERATORS=make

Do not need to find depot_tools and run GN when GYP_GENERATORS=make

When we build chromium with make, we do not need to find depot_tools and
run GN because they are only used for running ninja.

In this case, we can remove gtk+2 dependency in build environment because
GN has gtk+2 dependency.

BUG=none

[joone, 2014-02-07 19:30:59]

Hi,

Please take a look at my patch.

[Paweł Hajdan Jr., 2014-02-10 18:43:24]

Thank you for the patch. Some comments.

https://codereview.chromium.org/142853004/diff/1/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/142853004/diff/1/build/gyp_chromium#newcode377
build/gyp_chromium:377: depot_tools_path =
find_depot_tools.add_depot_tools_to_path()
find_depot_tools is actually used here (and a couple more places). Looks like
the patch would break it.

https://codereview.chromium.org/142853004/diff/1/build/gyp_chromium#newcode477
build/gyp_chromium:477: import find_depot_tools
It's not obvious why find_depot_tools would be needed here.

Also, GYP_GENERATORS=ninja in env is _not_ needed to enable ninja. Some
platforms already default to it.

[joone, 2014-02-14 22:15:17]

On 2014/02/10 18:43:24, Paweł Hajdan Jr. wrote:
> Thank you for the patch. Some comments.
> 
> https://codereview.chromium.org/142853004/diff/1/build/gyp_chromium
> File build/gyp_chromium (right):
> 
> https://codereview.chromium.org/142853004/diff/1/build/gyp_chromium#newcode377
> build/gyp_chromium:377: depot_tools_path =
> find_depot_tools.add_depot_tools_to_path()
> find_depot_tools is actually used here (and a couple more places). Looks like
> the patch would break it.
> 
> https://codereview.chromium.org/142853004/diff/1/build/gyp_chromium#newcode477
> build/gyp_chromium:477: import find_depot_tools
> It's not obvious why find_depot_tools would be needed here.
> 
> Also, GYP_GENERATORS=ninja in env is _not_ needed to enable ninja. Some
> platforms already default to it.

Checking "GYP_GENERATORS=make" seems more reasonable.
I will update the patch soon.
Thanks for the review.

[Paweł Hajdan Jr., 2014-02-14 23:48:35]

On 2014/02/14 22:15:17, joone wrote:
> Checking "GYP_GENERATORS=make" seems more reasonable.
> I will update the patch soon.
> Thanks for the review.

Please note the make generator can go away or break at any time. I strongly
recommend discussing this on chromium-dev if you still rely on the make build
and can't switch to ninja.

[Nico, 2014-02-17 05:45:58]

This does not lgtm. gn is currently unused, but will be used to generate _gyp_
files soon, which can then be used with any gyp generator. (Note that the make
generator is no longer supported for building chromium.) So gn isn't really
strongly connected to ninja at this point. (Eventually, once all gyp files are
converted to gn files, gn will generate ninja files directly instead of gyp
files, but that will take a while.)

[joone, 2014-02-17 19:05:45]

On 2014/02/17 05:45:58, Nico (away Feb 11 - Feb 17) wrote:
> This does not lgtm. gn is currently unused, but will be used to generate _gyp_
> files soon, which can then be used with any gyp generator. (Note that the make
> generator is no longer supported for building chromium.) So gn isn't really
> strongly connected to ninja at this point. (Eventually, once all gyp files are
> converted to gn files, gn will generate ninja files directly instead of gyp
> files, but that will take a while.)

Okay, I will try to use ninja in our build environment.

Thanks!