Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: src/hydrogen.h

Issue 14284010: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Make constructor of HObjectAccess and HObjectAccess::Portion private. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/hydrogen.cc » ('j') | src/hydrogen.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.h
diff --git a/src/hydrogen.h b/src/hydrogen.h
index 8df7a297269fb1000e7ed8eacc5fbcb58fbbd2ea..4a089e38b35e6b75ff4a3368e17a3b885fd73b61 100644
--- a/src/hydrogen.h
+++ b/src/hydrogen.h
@@ -999,17 +999,19 @@ class HGraphBuilder {
bool is_store,
KeyedAccessStoreMode store_mode);
- HValue* BuildCheckForCapacityGrow(HValue* object,
- HValue* elements,
- ElementsKind kind,
- HValue* length,
- HValue* key,
- bool is_js_array);
+ HValue* BuildCheckForCapacityGrow(
danno 2013/05/08 12:05:35 In general, please avoid extraneous whitespace cha
titzer 2013/05/08 15:15:45 Done.
+ HValue* object,
+ HValue* elements,
+ ElementsKind kind,
+ HValue* length,
+ HValue* key,
+ bool is_js_array);
- HValue* BuildCopyElementsOnWrite(HValue* object,
- HValue* elements,
- ElementsKind kind,
- HValue* length);
+ HValue* BuildCopyElementsOnWrite(
+ HValue* object,
+ HValue* elements,
+ ElementsKind kind,
+ HValue* length);
HInstruction* BuildUncheckedMonomorphicElementAccess(
HValue* object,
@@ -1022,8 +1024,19 @@ class HGraphBuilder {
KeyedAccessStoreMode store_mode,
Representation checked_index_representation = Representation::None());
- HInstruction* BuildStoreMap(HValue* object, HValue* map);
- HInstruction* BuildStoreMap(HValue* object, Handle<Map> map);
+ HLoadNamedField * AddLoad(
+ HValue *object,
+ HObjectAccess access,
+ HValue *typecheck = NULL,
+ Representation representation = Representation::Tagged());
+
+ HStoreNamedField* AddStore(
+ HValue *object,
+ HObjectAccess access,
+ HValue *val,
+ Representation representation = Representation::Tagged());
+
+ HStoreNamedField* AddStoreMapConstant(HValue *object, Handle<Map>);
HLoadNamedField* AddLoadElements(HValue *object, HValue *typecheck = NULL);
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/hydrogen.cc » ('j') | src/hydrogen.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698