Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts

src/hydrogen.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 981 matching lines @@
 
   HInstruction* BuildFastElementAccess(
       HValue* elements,
       HValue* checked_key,
       HValue* val,
       HValue* dependency,
       ElementsKind elements_kind,
       bool is_store,
       KeyedAccessStoreMode store_mode);
 
-  HValue* BuildCheckForCapacityGrow(HValue* object,
-                                    HValue* elements,
-                                    ElementsKind kind,
-                                    HValue* length,
-                                    HValue* key,
-                                    bool is_js_array);
+  HValue* BuildCheckForCapacityGrow(

[danno, 2013/05/08 12:05:35]

In general, please avoid extraneous whitespace changes, they just make the
likelihood of being able to merge this patch to other branches in other contexts
lower. If you want to do whitespace cleanup (in this case it's a bit iffy if
it's necessary), then please in another CL.

[titzer, 2013/05/08 15:15:45]

Done.

+      HValue* object,
+      HValue* elements,
+      ElementsKind kind,
+      HValue* length,
+      HValue* key,
+      bool is_js_array);
 
-  HValue* BuildCopyElementsOnWrite(HValue* object,
-                                   HValue* elements,
-                                   ElementsKind kind,
-                                   HValue* length);
+  HValue* BuildCopyElementsOnWrite(
+      HValue* object,
+      HValue* elements,
+      ElementsKind kind,
+      HValue* length);
 
   HInstruction* BuildUncheckedMonomorphicElementAccess(
       HValue* object,
       HValue* key,
       HValue* val,
       HCheckMaps* mapcheck,
       bool is_js_array,
       ElementsKind elements_kind,
       bool is_store,
       KeyedAccessStoreMode store_mode,
       Representation checked_index_representation = Representation::None());
 
-  HInstruction* BuildStoreMap(HValue* object, HValue* map);
-  HInstruction* BuildStoreMap(HValue* object, Handle<Map> map);
+  HLoadNamedField * AddLoad(
+      HValue *object,
+      HObjectAccess access,
+      HValue *typecheck = NULL,
+      Representation representation = Representation::Tagged());
+
+  HStoreNamedField* AddStore(
+      HValue *object,
+      HObjectAccess access,
+      HValue *val,
+      Representation representation = Representation::Tagged());
+
+  HStoreNamedField* AddStoreMapConstant(HValue *object, Handle<Map>);
 
   HLoadNamedField* AddLoadElements(HValue *object, HValue *typecheck = NULL);
 
   class IfBuilder {
    public:
     explicit IfBuilder(HGraphBuilder* builder,
                        int position = RelocInfo::kNoPosition);
     IfBuilder(HGraphBuilder* builder,
               HIfContinuation* continuation);
 
@@ skipping 968 matching lines @@
   EmbeddedVector<char, 64> filename_;
   HeapStringAllocator string_allocator_;
   StringStream trace_;
   int indent_;
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_HYDROGEN_H_