src/arm/lithium-arm.cc - Issue 14284010: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-arm.cc

Issue 14284010: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Make constructor of HObjectAccess and HObjectAccess::Portion private. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/lithium-arm.cc

diff --git a/src/arm/lithium-arm.cc b/src/arm/lithium-arm.cc

index 4768cc82a41fa68a0cee12d94f0624f4a8c84ccb..5cd71820d93b83901220d54ba06e2e2656335281 100644

--- a/src/arm/lithium-arm.cc

+++ b/src/arm/lithium-arm.cc

@@ -378,8 +378,7 @@ void LAccessArgumentsAt::PrintDataTo(StringStream* stream) {

void LStoreNamedField::PrintDataTo(StringStream* stream) {

object()->PrintTo(stream);

- stream->Add(".");

- stream->Add(*String::cast(*name())->ToCString());

+ stream->Add(".@%d", offset()); // TODO(titzer): use HObjectAccess

stream->Add(" <- ");

value()->PrintTo(stream);

}

« no previous file with comments | « no previous file | src/code-stubs-hydrogen.cc » ('j') | src/hydrogen.h » ('J')