Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1428373003: Minor cleanup (Closed)

Created:
5 years, 1 month ago by siva
Modified:
5 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Minor cleanup - remove ThreadInterruptCallback typedef as it is not used anymore - move InterruptedThreadState to thread_interrupter.h BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/9dee5b7a158ba2e5e9c3f60e6b33f6b5fc38bea0

Patch Set 1 #

Total comments: 2

Patch Set 2 : address-code-review-comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M runtime/vm/profiler.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/thread.h View 1 chunk +0 lines, -19 lines 0 comments Download
M runtime/vm/thread_interrupter.h View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
siva
5 years, 1 month ago (2015-11-06 20:05:32 UTC) #2
Cutch
LGTM with one note https://codereview.chromium.org/1428373003/diff/1/runtime/vm/thread.h File runtime/vm/thread.h (left): https://codereview.chromium.org/1428373003/diff/1/runtime/vm/thread.h#oldcode111 runtime/vm/thread.h:111: typedef void (*ThreadInterruptCallback)(Thread* thread, Please ...
5 years, 1 month ago (2015-11-06 20:10:15 UTC) #3
siva
https://codereview.chromium.org/1428373003/diff/1/runtime/vm/thread.h File runtime/vm/thread.h (left): https://codereview.chromium.org/1428373003/diff/1/runtime/vm/thread.h#oldcode111 runtime/vm/thread.h:111: typedef void (*ThreadInterruptCallback)(Thread* thread, On 2015/11/06 20:10:15, Cutch wrote: ...
5 years, 1 month ago (2015-11-06 21:59:33 UTC) #4
siva
5 years, 1 month ago (2015-11-06 22:15:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
9dee5b7a158ba2e5e9c3f60e6b33f6b5fc38bea0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698