Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Unified Diff: runtime/vm/thread.h

Issue 1428373003: Minor cleanup (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address-code-review-comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/profiler.h ('k') | runtime/vm/thread_interrupter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread.h
diff --git a/runtime/vm/thread.h b/runtime/vm/thread.h
index 9bba418a5d6d8998bcfc8619c2256641a25085e6..34e3767e6d0e89f2b5d0c89919d83c631d395eed 100644
--- a/runtime/vm/thread.h
+++ b/runtime/vm/thread.h
@@ -91,25 +91,6 @@ class Zone;
CACHED_VM_OBJECTS_LIST(V) \
CACHED_ADDRESSES_LIST(V) \
-struct InterruptedThreadState {
- uintptr_t pc;
- uintptr_t csp;
- uintptr_t dsp;
- uintptr_t fp;
- uintptr_t lr;
-};
-
-// When a thread is interrupted the thread specific interrupt callback will be
-// invoked. Each callback is given an InterruptedThreadState and the user data
-// pointer. When inside a thread interrupt callback doing any of the following
-// is forbidden:
-// * Accessing TLS -- Because on Windows the callback will be running in a
-// different thread.
-// * Allocating memory -- Because this takes locks which may already be held,
-// resulting in a dead lock.
-// * Taking a lock -- See above.
-typedef void (*ThreadInterruptCallback)(Thread* thread,
- const InterruptedThreadState& state);
// A VM thread; may be executing Dart code or performing helper tasks like
// garbage collection or compilation. The Thread structure associated with
« no previous file with comments | « runtime/vm/profiler.h ('k') | runtime/vm/thread_interrupter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698