Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1428063009: Fix off-by-one (or off-by-one-sixtyfourth) error when checking what a column can hold. (Closed)

Created:
5 years, 1 month ago by mstensho (USE GERRIT)
Modified:
5 years, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix off-by-one (or off-by-one-sixtyfourth) error when checking what a column can hold. R=leviw@chromium.org Committed: https://crrev.com/b635dae7f5b2e29ff3050beaa344112d35483558 Cr-Commit-Position: refs/heads/master@{#358447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/multicol/first-line-in-block-with-padding-exact-fit.html View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/first-line-in-block-with-padding-exact-fit-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
mstensho (USE GERRIT)
5 years, 1 month ago (2015-11-06 09:05:58 UTC) #1
leviw_travelin_and_unemployed
lgtm
5 years, 1 month ago (2015-11-06 23:35:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428063009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428063009/1
5 years, 1 month ago (2015-11-06 23:35:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 23:42:17 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 23:43:00 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b635dae7f5b2e29ff3050beaa344112d35483558
Cr-Commit-Position: refs/heads/master@{#358447}

Powered by Google App Engine
This is Rietveld 408576698