third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp - Issue 1428063009: Fix off-by-one (or off-by-one-sixtyfourth) error when checking what a column can hold.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Issue 1428063009: Fix off-by-one (or off-by-one-sixtyfourth) error when checking what a column can hold. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/first-line-in-block-with-padding-exact-fit-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

index 862f15a1e029b99af83217c316e63de692c65db9..a2126f1588b389444b16d9e53ab08fc1b85fcd06 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

@@ -756,7 +756,7 @@ static inline bool shouldSetStrutOnBlock(const LayoutBlockFlow& block, const Roo

LayoutUnit pageLogicalHeightAtNewOffset = block.pageLogicalHeightForOffset(lineLogicalOffset + remainingLogicalHeight);

// It's rather pointless to break before the block if the current line isn't going to

// fit in the same column or page, so check that as well.

- if (totalLogicalHeight < pageLogicalHeightAtNewOffset)

+ if (totalLogicalHeight <= pageLogicalHeightAtNewOffset)

wantsStrutOnBlock = true;

}

return wantsStrutOnBlock && block.allowsPaginationStrut();

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/first-line-in-block-with-padding-exact-fit-expected.txt ('k') | no next file » | no next file with comments »