Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1427973004: Fix crash when combining text-emphasis with CSS variables (Closed)

Created:
5 years, 1 month ago by rwlbuis
Modified:
5 years, 1 month ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when combining text-emphasis with CSS variables Fix crash when combining text-emphasis with CSS variables by fixing an incorrect change in r357748. BUG=552870 Committed: https://crrev.com/0d5eecffd71e747e2034281c858d51c38da10768 Cr-Commit-Position: refs/heads/master@{#358561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/variables/webkit-text-emphasis-crash.html View 1 chunk +10 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/css/variables/webkit-text-emphasis-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
rwlbuis
PTAL, I believe this bit was lost in translation in the review of the CSS ...
5 years, 1 month ago (2015-11-08 23:17:40 UTC) #4
Timothy Loh
On 2015/11/08 23:17:40, rwlbuis wrote: > PTAL, I believe this bit was lost in translation ...
5 years, 1 month ago (2015-11-09 00:03:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427973004/1
5 years, 1 month ago (2015-11-09 00:09:35 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 01:14:59 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 01:15:34 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0d5eecffd71e747e2034281c858d51c38da10768
Cr-Commit-Position: refs/heads/master@{#358561}

Powered by Google App Engine
This is Rietveld 408576698