Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp

Issue 1427973004: Fix crash when combining text-emphasis with CSS variables (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/variables/webkit-text-emphasis-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
index 47752a01be89c89a84a64deefdd8f9a8afbbccb0..58d56073356b6b316aafcb9b22c8c0153b77b757 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
@@ -58,7 +58,7 @@ static inline void filterProperties(bool important, const WillBeHeapVector<CSSPr
const CSSProperty& property = input[i];
if (property.isImportant() != important)
continue;
- const unsigned propertyIDIndex = property.id();
+ const unsigned propertyIDIndex = property.id() - firstCSSProperty;
// All custom properties use the same CSSPropertyID so we can't remove repeated definitions
if (property.id() != CSSPropertyVariable) {
if (seenProperties.get(propertyIDIndex))
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/variables/webkit-text-emphasis-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698