Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 1427913003: [turbofan] Add support for loading missing properties. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for loading missing properties. Return undefined for missing properties (or throw an exception in strong mode). Also do a bit of code cleanup. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/8954ea1b6f5c8d4b540a506e25d9b1ce0ea4ba22 Cr-Commit-Position: refs/heads/master@{#31700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -40 lines) Patch
M src/compiler/js-native-context-specialization.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 5 chunks +18 lines, -5 lines 0 comments Download
M src/compiler/property-access-info.h View 2 chunks +9 lines, -10 lines 0 comments Download
M src/compiler/property-access-info.cc View 5 chunks +56 lines, -23 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-02 07:17:07 UTC) #1
Benedikt Meurer
Hey Jaro, This is the patch we're talking about offline. Please take a look. Thanks, ...
5 years, 1 month ago (2015-11-02 07:17:44 UTC) #2
Jarin
lgtm
5 years, 1 month ago (2015-11-02 07:21:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427913003/1
5 years, 1 month ago (2015-11-02 07:22:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 07:35:16 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 07:35:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8954ea1b6f5c8d4b540a506e25d9b1ce0ea4ba22
Cr-Commit-Position: refs/heads/master@{#31700}

Powered by Google App Engine
This is Rietveld 408576698