Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1414013004: [turbofan] Add support for keyed access to named properties. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@JSNativeContextSpecialization_NotFound
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for keyed access to named properties. The compiler can generate a named access for o[x] if x is a compile time constant that can be turned into a name using ToName (limited to primitive x values, because other ToName invocations might be observable), or the KeyedLoadIC/KeyedStoreIC have gather constant name feedback for x (i.e. the access always goes to the same symbol). R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/7fcad712ed65ef2811944ef8902106f675956cd5 Cr-Commit-Position: refs/heads/master@{#31703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -3 lines) Patch
M src/compiler/js-native-context-specialization.h View 3 chunks +9 lines, -1 line 0 comments Download
M src/compiler/js-native-context-specialization.cc View 4 chunks +92 lines, -2 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-02 08:28:09 UTC) #1
Benedikt Meurer
Hey Jaro, Initial keyed access support for named properties. Please take a look. Thanks, Benedikt
5 years, 1 month ago (2015-11-02 08:28:41 UTC) #2
Jarin
lgtm
5 years, 1 month ago (2015-11-02 08:53:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414013004/1
5 years, 1 month ago (2015-11-02 08:53:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 08:55:07 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 08:55:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fcad712ed65ef2811944ef8902106f675956cd5
Cr-Commit-Position: refs/heads/master@{#31703}

Powered by Google App Engine
This is Rietveld 408576698