[proxies] Remove "fix" functionality, add (still unused) target property.

[proxies] Remove "fix" functionality, add (still unused) target property.

BUG=

Committed: https://crrev.com/69d218c03ffa190e6a4f6e9bc83359b6601822ae
Cr-Commit-Position: refs/heads/master@{#31972}

[neis, 2015-11-10 16:30:48]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-10 16:30:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1427743011/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1427743011/1

[neis, 2015-11-10 16:46:27]

Description was changed from

==========
[proxies] Remove "fix" functionality, add (still unused) target property.

BUG=
==========

to

==========
[proxies] Remove "fix" functionality, add (still unused) target property.

BUG=
==========

[neis, 2015-11-10 16:46:27]

neis@chromium.org changed reviewers:
+ rossberg@chromium.org

[neis, 2015-11-10 16:46:44]

PTAL

[commit-bot: I haz the power, 2015-11-10 16:49:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-10 16:49:04]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2015-11-12 09:12:56]

cbruni@chromium.org changed reviewers:
+ cbruni@chromium.org

[Camillo Bruni, 2015-11-12 09:12:56]

adding some comments

https://codereview.chromium.org/1427743011/diff/1/src/factory.h
File src/factory.h (right):

https://codereview.chromium.org/1427743011/diff/1/src/factory.h#newcode481
src/factory.h:481: Handle<Object> prototype);
From my understanding of the old implementation prototype == target, no?
(probably missed something)

https://codereview.chromium.org/1427743011/diff/1/src/js/proxy.js
File src/js/proxy.js (right):

https://codereview.chromium.org/1427743011/diff/1/src/js/proxy.js#newcode33
src/js/proxy.js:33: return %CreateJSProxy({}, handler, proto)
As you can see from my CL, I changed this to directly use (target, handler) as
an argument and pass that along to %CreateProxy, probably related to my
observation further up.

https://codereview.chromium.org/1427743011/diff/1/test/mjsunit/harmony/proxie...
File test/mjsunit/harmony/proxies.js (right):

https://codereview.chromium.org/1427743011/diff/1/test/mjsunit/harmony/proxie...
test/mjsunit/harmony/proxies.js:1827: // TODO(neis): Reenable/adapt once proxies
properly support these operations.
For some reason I managed to pass most of these tests, minus some weird ones :)

[rossberg, 2015-11-12 16:46:26]

lgtm

https://codereview.chromium.org/1427743011/diff/1/src/js/v8natives.js
File src/js/v8natives.js (right):

https://codereview.chromium.org/1427743011/diff/1/src/js/v8natives.js#newcode...
src/js/v8natives.js:1124: // TODO(neis): For proxies, must call
preventExtensions trap first.
The call is already there, why not just reorder?

https://codereview.chromium.org/1427743011/diff/1/src/js/v8natives.js#newcode...
src/js/v8natives.js:1152: // TODO(neis): For proxies, must call
preventExtensions trap first.
Same here.

[neis, 2015-11-12 17:36:32]

camillo, are you okay with me landing this now?

https://codereview.chromium.org/1427743011/diff/1/src/js/v8natives.js
File src/js/v8natives.js (right):

https://codereview.chromium.org/1427743011/diff/1/src/js/v8natives.js#newcode...
src/js/v8natives.js:1124: // TODO(neis): For proxies, must call
preventExtensions trap first.
On 2015/11/12 16:46:26, rossberg wrote:
> The call is already there, why not just reorder?

It's possible that this is enough, assuming that %PreventExtensions works for
proxies, which it currently doesn't.  I have a CL in progress for that.

[Camillo Bruni, 2015-11-12 19:52:41]

LGTM and please land :) so I'merge (yes I am a merger) my CL tomorrow.

https://codereview.chromium.org/1427743011/diff/1/src/factory.h
File src/factory.h (right):

https://codereview.chromium.org/1427743011/diff/1/src/factory.h#newcode481
src/factory.h:481: Handle<Object> prototype);
On 2015/11/12 at 09:12:56, cbruni wrote:
> From my understanding of the old implementation prototype == target, no?
(probably missed something)

This should be fine then, prototype will simply be not used on Proxies.

[neis, 2015-11-12 21:52:31]

The CQ bit was checked by neis@chromium.org

[neis, 2015-11-12 21:52:32]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org,
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1427743011/#ps40001
(title: "Test")

[commit-bot: I haz the power, 2015-11-12 21:52:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1427743011/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1427743011/40001

[commit-bot: I haz the power, 2015-11-12 22:12:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-14 23:21:08]

Patchset 3 (id:??) landed as
https://crrev.com/69d218c03ffa190e6a4f6e9bc83359b6601822ae
Cr-Commit-Position: refs/heads/master@{#31972}