Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: src/objects.cc

Issue 1427743011: [proxies] Remove "fix" functionality, add (still unused) target property. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 4ca3fead1782def067a3f38d354dc2791547ebff..74ee5a32bc627833466ea84842b13800148672ac 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -4654,28 +4654,6 @@ Maybe<PropertyAttributes> JSProxy::GetPropertyAttributesWithHandler(
}
-void JSProxy::Fix(Handle<JSProxy> proxy) {
- Isolate* isolate = proxy->GetIsolate();
-
- // Save identity hash.
- Handle<Object> hash(proxy->GetIdentityHash(), isolate);
-
- if (proxy->IsJSFunctionProxy()) {
- isolate->factory()->BecomeJSFunction(proxy);
- // Code will be set on the JavaScript side.
- } else {
- isolate->factory()->BecomeJSObject(proxy);
- }
- DCHECK(proxy->IsJSObject());
-
- // Inherit identity, if it was present.
- if (hash->IsSmi()) {
- JSObject::SetIdentityHash(Handle<JSObject>::cast(proxy),
- Handle<Smi>::cast(hash));
- }
-}
-
-
MaybeHandle<Object> JSProxy::CallTrap(Handle<JSProxy> proxy,
const char* name,
Handle<Object> derived,
@@ -8421,25 +8399,6 @@ Handle<Map> Map::CopyForPreventExtensions(Handle<Map> map,
}
-Handle<Map> Map::FixProxy(Handle<Map> map, InstanceType type, int size) {
- DCHECK(type == JS_OBJECT_TYPE || type == JS_FUNCTION_TYPE);
- DCHECK(map->IsJSProxyMap());
-
- Isolate* isolate = map->GetIsolate();
-
- // Allocate fresh map.
- // TODO(rossberg): Once we optimize proxies, cache these maps.
- Handle<Map> new_map = isolate->factory()->NewMap(type, size);
-
- Handle<Object> prototype(map->prototype(), isolate);
- Map::SetPrototype(new_map, prototype);
-
- map->NotifyLeafMapLayoutChange();
-
- return new_map;
-}
-
-
bool DescriptorArray::CanHoldValue(int descriptor, Object* value) {
PropertyDetails details = GetDetails(descriptor);
switch (details.type()) {
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698