chrome/android/java/src/org/chromium/chrome/browser/physicalweb/HttpRequest.java - Issue 1427663004: Use BitmapHttpRequest to fetch favicon for Nearby URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/HttpRequest.java

Issue 1427663004: Use BitmapHttpRequest to fetch favicon for Nearby URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wip (taking changes from dfalcantara,dvh) Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/HttpRequest.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/HttpRequest.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/HttpRequest.java

index d4e3f5f58c3b9c7c66889687019a201638160d3f..d09ff5e38db2d2c1f17e1504d2586e3ce3042f99 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/HttpRequest.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/HttpRequest.java

@@ -70,7 +70,6 @@ abstract class HttpRequest<T> implements Runnable {

// Make the request

try {

urlConnection = (HttpURLConnection) mUrl.openConnection();

- urlConnection.setDoOutput(true);

writeToUrlConnection(urlConnection);

responseCode = urlConnection.getResponseCode();

inputStream = new BufferedInputStream(urlConnection.getInputStream());

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/physicalweb/JsonObjectHttpRequest.java » ('j') | no next file with comments »