Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1394)

Unified Diff: content/public/test/render_view_test.h

Issue 1427633004: Send navigation_start to the browser in DidStartProvisionalLoad IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation_start_renderer
Patch Set: Write GoToOffsetWithParams to use GoToOffset (DRY) Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/navigation_handle.cc ('k') | content/public/test/render_view_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/render_view_test.h
diff --git a/content/public/test/render_view_test.h b/content/public/test/render_view_test.h
index 5ae89cfff3f3e97c501faf464be268cb2965237e..02fb396f726b4ec0de55600fbe3912a5fe8584b4 100644
--- a/content/public/test/render_view_test.h
+++ b/content/public/test/render_view_test.h
@@ -36,6 +36,7 @@ class RendererScheduler;
}
namespace content {
+struct CommonNavigationParams;
clamy 2015/11/05 17:35:06 I don't think these content internal classes shoul
class ContentBrowserClient;
class ContentClient;
class ContentRendererClient;
@@ -45,6 +46,8 @@ class PageState;
class RendererMainPlatformDelegate;
class RendererBlinkPlatformImplNoSandboxImpl;
class RenderView;
+struct RequestNavigationParams;
+struct StartNavigationParams;
class RenderViewTest : public testing::Test, blink::WebLeakDetectorClient {
public:
@@ -197,7 +200,13 @@ class RenderViewTest : public testing::Test, blink::WebLeakDetectorClient {
scoped_ptr<base::mac::ScopedNSAutoreleasePool> autorelease_pool_;
#endif
- private:
+ protected:
+ // Will overwrite fields in request_params to prepare for navigation.
+ void GoToOffsetWithParams(int offset,
clamy 2015/11/05 17:35:06 These content internal classes should not appear o
+ const PageState& state,
+ const CommonNavigationParams common_params,
+ const StartNavigationParams start_params,
+ RequestNavigationParams request_params);
void GoToOffset(int offset, const PageState& state);
};
« no previous file with comments | « content/public/browser/navigation_handle.cc ('k') | content/public/test/render_view_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698