Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: content/public/test/render_view_test.h

Issue 1427633004: Send navigation_start to the browser in DidStartProvisionalLoad IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation_start_renderer
Patch Set: Write GoToOffsetWithParams to use GoToOffset (DRY) Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/browser/navigation_handle.cc ('k') | content/public/test/render_view_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_TEST_RENDER_VIEW_TEST_H_ 5 #ifndef CONTENT_PUBLIC_TEST_RENDER_VIEW_TEST_H_
6 #define CONTENT_PUBLIC_TEST_RENDER_VIEW_TEST_H_ 6 #define CONTENT_PUBLIC_TEST_RENDER_VIEW_TEST_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 18 matching lines...) Expand all
29 29
30 namespace gfx { 30 namespace gfx {
31 class Rect; 31 class Rect;
32 } 32 }
33 33
34 namespace scheduler { 34 namespace scheduler {
35 class RendererScheduler; 35 class RendererScheduler;
36 } 36 }
37 37
38 namespace content { 38 namespace content {
39 struct CommonNavigationParams;
clamy 2015/11/05 17:35:06 I don't think these content internal classes shoul
39 class ContentBrowserClient; 40 class ContentBrowserClient;
40 class ContentClient; 41 class ContentClient;
41 class ContentRendererClient; 42 class ContentRendererClient;
42 class FakeCompositorDependencies; 43 class FakeCompositorDependencies;
43 class MockRenderProcess; 44 class MockRenderProcess;
44 class PageState; 45 class PageState;
45 class RendererMainPlatformDelegate; 46 class RendererMainPlatformDelegate;
46 class RendererBlinkPlatformImplNoSandboxImpl; 47 class RendererBlinkPlatformImplNoSandboxImpl;
47 class RenderView; 48 class RenderView;
49 struct RequestNavigationParams;
50 struct StartNavigationParams;
48 51
49 class RenderViewTest : public testing::Test, blink::WebLeakDetectorClient { 52 class RenderViewTest : public testing::Test, blink::WebLeakDetectorClient {
50 public: 53 public:
51 // A special BlinkPlatformImpl class for getting rid off the dependency to the 54 // A special BlinkPlatformImpl class for getting rid off the dependency to the
52 // sandbox, which is not available in RenderViewTest. 55 // sandbox, which is not available in RenderViewTest.
53 class RendererBlinkPlatformImplNoSandbox { 56 class RendererBlinkPlatformImplNoSandbox {
54 public: 57 public:
55 RendererBlinkPlatformImplNoSandbox(); 58 RendererBlinkPlatformImplNoSandbox();
56 ~RendererBlinkPlatformImplNoSandbox(); 59 ~RendererBlinkPlatformImplNoSandbox();
57 blink::Platform* Get() const; 60 blink::Platform* Get() const;
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 193
191 // Used to setup the process so renderers can run. 194 // Used to setup the process so renderers can run.
192 scoped_ptr<RendererMainPlatformDelegate> platform_; 195 scoped_ptr<RendererMainPlatformDelegate> platform_;
193 scoped_ptr<MainFunctionParams> params_; 196 scoped_ptr<MainFunctionParams> params_;
194 scoped_ptr<base::CommandLine> command_line_; 197 scoped_ptr<base::CommandLine> command_line_;
195 198
196 #if defined(OS_MACOSX) 199 #if defined(OS_MACOSX)
197 scoped_ptr<base::mac::ScopedNSAutoreleasePool> autorelease_pool_; 200 scoped_ptr<base::mac::ScopedNSAutoreleasePool> autorelease_pool_;
198 #endif 201 #endif
199 202
200 private: 203 protected:
204 // Will overwrite fields in request_params to prepare for navigation.
205 void GoToOffsetWithParams(int offset,
clamy 2015/11/05 17:35:06 These content internal classes should not appear o
206 const PageState& state,
207 const CommonNavigationParams common_params,
208 const StartNavigationParams start_params,
209 RequestNavigationParams request_params);
201 void GoToOffset(int offset, const PageState& state); 210 void GoToOffset(int offset, const PageState& state);
202 }; 211 };
203 212
204 } // namespace content 213 } // namespace content
205 214
206 #endif // CONTENT_PUBLIC_TEST_RENDER_VIEW_TEST_H_ 215 #endif // CONTENT_PUBLIC_TEST_RENDER_VIEW_TEST_H_
OLDNEW
« no previous file with comments | « content/public/browser/navigation_handle.cc ('k') | content/public/test/render_view_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698