Issue 1427583009: 1. Get rid of SwitchIsolateScope as it is not clear when this should be used and there is also a bu…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1427583009: 1. Get rid of SwitchIsolateScope as it is not clear when this should be used and there is also a bu… (Closed)

Created:
5 years, 1 month ago by siva

Modified:
5 years, 1 month ago

Reviewers:
zra

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

1. Get rid of SwitchIsolateScope as it is not clear when this should be used and there is also a bug in that Thread::ExitIsolate is not called if saved_isolate is not NULL 2. Added Dart::ShutDownIsolate(Isolate* isolate) to take care of ensuring that the isolate is entered before shutting it down and deal with the asymmetry on the way out. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/10f40ce373c9595e0dffb501465a7fb43d6d5e75

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -54 lines)			Patch
M	runtime/vm/dart.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/isolate.h	View	1 chunk	+0 lines, -42 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/service_isolate.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

siva

5 years, 1 month ago (2015-11-02 22:29:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
10f40ce373c9595e0dffb501465a7fb43d6d5e75 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages