Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: runtime/vm/service_isolate.cc

Issue 1427583009: 1. Get rid of SwitchIsolateScope as it is not clear when this should be used and there is also a bu… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/isolate.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/service_isolate.h" 5 #include "vm/service_isolate.h"
6 6
7 #include "vm/compiler.h" 7 #include "vm/compiler.h"
8 #include "vm/dart_api_impl.h" 8 #include "vm/dart_api_impl.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/isolate.h" 10 #include "vm/isolate.h"
(...skipping 342 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 ASSERT(I == T->isolate()); 353 ASSERT(I == T->isolate());
354 StackZone zone(T); 354 StackZone zone(T);
355 HandleScope handle_scope(T); 355 HandleScope handle_scope(T);
356 Error& error = Error::Handle(Z); 356 Error& error = Error::Handle(Z);
357 error = I->object_store()->sticky_error(); 357 error = I->object_store()->sticky_error();
358 if (!error.IsNull() && !error.IsUnwindError()) { 358 if (!error.IsNull() && !error.IsUnwindError()) {
359 OS::PrintErr("vm-service: Error: %s\n", error.ToErrorCString()); 359 OS::PrintErr("vm-service: Error: %s\n", error.ToErrorCString());
360 } 360 }
361 Dart::RunShutdownCallback(); 361 Dart::RunShutdownCallback();
362 } 362 }
363 { 363 // Shut the isolate down.
364 // Shut the isolate down. 364 Dart::ShutdownIsolate(I);
365 SwitchIsolateScope switch_scope(I);
366 Dart::ShutdownIsolate();
367 }
368 if (FLAG_trace_service) { 365 if (FLAG_trace_service) {
369 OS::Print("vm-service: Shutdown.\n"); 366 OS::Print("vm-service: Shutdown.\n");
370 } 367 }
371 ServiceIsolate::FinishedExiting(); 368 ServiceIsolate::FinishedExiting();
372 } 369 }
373 370
374 void RunMain(Isolate* I) { 371 void RunMain(Isolate* I) {
375 Thread* T = Thread::Current(); 372 Thread* T = Thread::Current();
376 ASSERT(I == T->isolate()); 373 ASSERT(I == T->isolate());
377 StackZone zone(T); 374 StackZone zone(T);
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
487 ASSERT(!result.IsNull()); 484 ASSERT(!result.IsNull());
488 Dart_Port port = ILLEGAL_PORT; 485 Dart_Port port = ILLEGAL_PORT;
489 if (result.IsReceivePort()) { 486 if (result.IsReceivePort()) {
490 port = ReceivePort::Cast(result).Id(); 487 port = ReceivePort::Cast(result).Id();
491 } 488 }
492 ASSERT(port != ILLEGAL_PORT); 489 ASSERT(port != ILLEGAL_PORT);
493 ServiceIsolate::SetServicePort(port); 490 ServiceIsolate::SetServicePort(port);
494 } 491 }
495 492
496 } // namespace dart 493 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/isolate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698